Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(5899)

Unified Diff: chrome/installer/util/google_update_util.cc

Issue 927443004: Remove uses of WaitForExitCodeWithTimeout (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 5 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | win8/delegate_execute/chrome_util.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/installer/util/google_update_util.cc
diff --git a/chrome/installer/util/google_update_util.cc b/chrome/installer/util/google_update_util.cc
index 5140146ad2e69de96f91d1fb94925f9341f95d1a..3a8558f56b0d2e66268f83c409501b8d05f8428b 100644
--- a/chrome/installer/util/google_update_util.cc
+++ b/chrome/installer/util/google_update_util.cc
@@ -95,8 +95,7 @@ bool LaunchProcessAndWaitWithTimeout(const base::string16& cmd_string,
base::LaunchProcess(cmd_string, base::LaunchOptions());
if (!process.IsValid()) {
PLOG(ERROR) << "Failed to launch (" << cmd_string << ")";
- } else if (!base::WaitForExitCodeWithTimeout(process.Handle(), &exit_code,
- timeout)) {
+ } else if (!process.WaitForExitWithTimeout(timeout, &exit_code)) {
// The GetExitCodeProcess failed or timed-out.
LOG(ERROR) <<"Command (" << cmd_string << ") is taking more than "
<< timeout.InMilliseconds() << " milliseconds to complete.";
« no previous file with comments | « no previous file | win8/delegate_execute/chrome_util.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698