Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(196)

Issue 927433003: Track whether notification permission requests are made at the top-level. (Closed)

Created:
5 years, 10 months ago by Peter Beverloo
Modified:
5 years, 10 months ago
CC:
asvitkine+watch_chromium.org, chromium-reviews, mlamouri+watch-notifications_chromium.org, peter+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Track whether notification permission requests are made at the top-level. This patch adds a histogram tracking whether the requesting and the embedding origin are different when requesting permission to display Web Notifications. Notifications currently don't have this requirement, but it would be great if we can introduce it. BUG=416894 Committed: https://crrev.com/1398c49250282871b85fdfb0ea8dd00c13f6ae81 Cr-Commit-Position: refs/heads/master@{#316838}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+16 lines, -0 lines) Patch
M chrome/browser/notifications/desktop_notification_service.cc View 2 chunks +7 lines, -0 lines 0 comments Download
M tools/metrics/histograms/histograms.xml View 1 chunk +9 lines, -0 lines 0 comments Download

Messages

Total messages: 9 (3 generated)
Peter Beverloo
+asvitkine for histogram addition
5 years, 10 months ago (2015-02-18 11:46:38 UTC) #2
mlamouri (slow - plz ping)
lgtm
5 years, 10 months ago (2015-02-18 11:53:00 UTC) #4
Alexei Svitkine (slow)
lgtm
5 years, 10 months ago (2015-02-18 15:26:05 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/927433003/1
5 years, 10 months ago (2015-02-18 15:43:34 UTC) #7
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 10 months ago (2015-02-18 16:26:07 UTC) #8
commit-bot: I haz the power
5 years, 10 months ago (2015-02-18 16:27:16 UTC) #9
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/1398c49250282871b85fdfb0ea8dd00c13f6ae81
Cr-Commit-Position: refs/heads/master@{#316838}

Powered by Google App Engine
This is Rietveld 408576698