Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(214)

Issue 92743002: Extract UI dependencies from ExtensionHost, part 3 (Closed)

Created:
7 years ago by James Cook
Modified:
7 years ago
Reviewers:
Yoyo Zhou, bulach
CC:
chromium-reviews, chromium-apps-reviews_chromium.org, extensions-reviews_chromium.org
Visibility:
Public.

Description

Extract UI dependencies from ExtensionHost, part 3 1. Move WebContentsModalDialog support to ExtensionViewHost, as it is only used by extension popups. 2. Break reliance on ChromeWebModalDialogManagerDelegate by providing our own one-line IsWebContentsVisible() implementation. 3. Remove a bunch of OS_ANDROID ifdefs, since Android can use the components module where web_modal stuff is implemented. BUG=321341 TEST=browser_tests, esp. DownloadExtensionTest.DownloadExtensionTest_AcceptDanger Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=238436

Patch Set 1 #

Patch Set 2 : . #

Patch Set 3 : rebase extension_view_host #

Unified diffs Side-by-side diffs Delta from patch set Stats (+117 lines, -102 lines) Patch
M chrome/browser/extensions/extension_host.h View 1 2 5 chunks +5 lines, -30 lines 0 comments Download
M chrome/browser/extensions/extension_host.cc View 1 2 5 chunks +2 lines, -64 lines 0 comments Download
M chrome/browser/extensions/extension_view_host.h View 4 chunks +24 lines, -3 lines 0 comments Download
M chrome/browser/extensions/extension_view_host.cc View 1 2 8 chunks +83 lines, -5 lines 0 comments Download
M chrome/browser/ui/android/extensions/extension_view_android.h View 1 chunk +3 lines, -0 lines 0 comments Download

Messages

Total messages: 8 (0 generated)
James Cook
yoz, PTAL bulach, can I get OWNERS for adding another stub function to c/b/ui/android/extension_view_android.h ?
7 years ago (2013-11-27 22:20:06 UTC) #1
bulach
lgtm for android, thanks!
7 years ago (2013-11-28 09:19:35 UTC) #2
James Cook
yoz, friendly ping?
7 years ago (2013-12-02 21:36:44 UTC) #3
Yoyo Zhou
LGTM
7 years ago (2013-12-02 23:24:42 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/jamescook@chromium.org/92743002/40001
7 years ago (2013-12-02 23:33:29 UTC) #5
commit-bot: I haz the power
Retried try job too often on mac_rel for step(s) browser_tests http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=mac_rel&number=195680
7 years ago (2013-12-03 01:59:59 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/jamescook@chromium.org/92743002/40001
7 years ago (2013-12-03 16:48:41 UTC) #7
commit-bot: I haz the power
7 years ago (2013-12-03 18:39:57 UTC) #8
Message was sent while issue was closed.
Change committed as 238436

Powered by Google App Engine
This is Rietveld 408576698