Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(245)

Issue 9274003: GYP infrastructure for App Mode app launcher (Closed)

Created:
8 years, 11 months ago by jeremy
Modified:
8 years, 11 months ago
CC:
chromium-reviews
Visibility:
Public.

Description

GYP infrastructure for App Mode app launcher * Refactor app mode app into a static library + executable target. * Add a test target + main test runner file (no tests for now). * Make app mode app depend on base so we can use logging and DCHECKs, etc. In the interests of keeping this CL small, no tests are added and app_mode_loader_mac.mm isn't changed to use base/ functionality. TEST=NONE BUG=NONE Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=118966

Patch Set 1 #

Total comments: 1

Patch Set 2 : Fix make build #

Unified diffs Side-by-side diffs Delta from patch set Stats (+56 lines, -3 lines) Patch
M chrome/chrome.gyp View 1 1 chunk +21 lines, -2 lines 0 comments Download
M chrome/chrome_tests.gypi View 1 1 chunk +24 lines, -1 line 0 comments Download
A chrome/test/base/app_mode_app_tests.cc View 1 chunk +11 lines, -0 lines 0 comments Download

Messages

Total messages: 10 (0 generated)
jeremy
Mark: Review please - I've tried to stay as close as I could to the ...
8 years, 11 months ago (2012-01-22 15:17:28 UTC) #1
jeremy
Mihai: *Files = chrome/app/app_mode_loader_mac.mm, chrome/test/base/app_mode_app_tests.cc
8 years, 11 months ago (2012-01-22 15:24:25 UTC) #2
Mark Mentovai
LGTM otherwise. https://chromiumcodereview.appspot.com/9274003/diff/1/chrome/chrome.gyp File chrome/chrome.gyp (right): https://chromiumcodereview.appspot.com/9274003/diff/1/chrome/chrome.gyp#newcode824 chrome/chrome.gyp:824: # This produces the app mode loader, ...
8 years, 11 months ago (2012-01-23 16:08:08 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/jeremy@chromium.org/9274003/7001
8 years, 11 months ago (2012-01-24 13:13:26 UTC) #4
commit-bot: I haz the power
Try job failure for 9274003-7001 (retry) on win_rel for step "unit_tests" (clobber build). It's a ...
8 years, 11 months ago (2012-01-24 15:00:26 UTC) #5
Mihai Parparita -not on Chrome
Belated LGTM
8 years, 11 months ago (2012-01-24 17:47:40 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/jeremy@chromium.org/9274003/7001
8 years, 11 months ago (2012-01-24 17:47:47 UTC) #7
commit-bot: I haz the power
Try job failure for 9274003-7001 (retry) (retry) on win_rel for step "base_unittests" (clobber build). It's ...
8 years, 11 months ago (2012-01-24 22:24:22 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/jeremy@chromium.org/9274003/7001
8 years, 11 months ago (2012-01-24 22:32:25 UTC) #9
commit-bot: I haz the power
8 years, 11 months ago (2012-01-25 01:17:23 UTC) #10
Change committed as 118966

Powered by Google App Engine
This is Rietveld 408576698