Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(51)

Unified Diff: remoting/webapp/browser_test/update_pin_browser_test.js

Issue 927373005: [Chromoting] Enable jscompile for browser tests. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Fix unittests; More review comments Created 5 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « remoting/webapp/browser_test/timeout_waiter.js ('k') | remoting/webapp/crd/js/client_session.js » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: remoting/webapp/browser_test/update_pin_browser_test.js
diff --git a/remoting/webapp/browser_test/update_pin_browser_test.js b/remoting/webapp/browser_test/update_pin_browser_test.js
index 370ed1f4890e5c95d7ffd5813a10f20fccdcca70..964684171b955a8815af5a0bda7d8f67dc10aea9 100644
--- a/remoting/webapp/browser_test/update_pin_browser_test.js
+++ b/remoting/webapp/browser_test/update_pin_browser_test.js
@@ -18,6 +18,9 @@
/** @constructor */
browserTest.Update_PIN = function() {};
+/**
+ * @param {{new_pin:string, old_pin:string}} data
+ */
browserTest.Update_PIN.prototype.run = function(data) {
var LOGIN_BACKOFF_WAIT = 2000;
// Input validation
@@ -36,7 +39,7 @@ browserTest.Update_PIN.prototype.run = function(data) {
).then(
browserTest.connectMe2Me
).then(function(){
- return browserTest.enterPIN_(data.new_pin, false /* expectError*/)
+ return browserTest.enterPIN(data.new_pin, false /* expectError*/)
}).then(
// Clean up the test by disconnecting and changing the PIN back
browserTest.disconnect
@@ -52,6 +55,10 @@ browserTest.Update_PIN.prototype.run = function(data) {
);
};
+/**
+ * @param {string} newPin
+ * @return {Promise}
+ */
browserTest.Update_PIN.prototype.changePIN_ = function(newPin) {
var AppMode = remoting.AppMode;
var HOST_RESTART_WAIT = 10000;
« no previous file with comments | « remoting/webapp/browser_test/timeout_waiter.js ('k') | remoting/webapp/crd/js/client_session.js » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698