Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(498)

Unified Diff: remoting/webapp/browser_test/scrollbar_browser_test.js

Issue 927373005: [Chromoting] Enable jscompile for browser tests. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Fix unittests; More review comments Created 5 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: remoting/webapp/browser_test/scrollbar_browser_test.js
diff --git a/remoting/webapp/browser_test/scrollbar_browser_test.js b/remoting/webapp/browser_test/scrollbar_browser_test.js
index 2424c8ce5764ae2cc648213cc2e1ccd212fe290f..98ca55560c57179634b2e5aa660b2fbc4f641372 100644
--- a/remoting/webapp/browser_test/scrollbar_browser_test.js
+++ b/remoting/webapp/browser_test/scrollbar_browser_test.js
@@ -53,6 +53,7 @@ browserTest.Scrollbars.prototype.run = function(data) {
/**
* Verify the test cases for the home-screen.
+ * @return {Promise}
*/
browserTest.Scrollbars.prototype.verifyHomeScreenScrollbars_ = function() {
// Note that, due to crbug.com/240772, if the window already has
@@ -126,6 +127,7 @@ browserTest.Scrollbars.prototype.verifyHomeScreenScrollbars_ = function() {
* scroll-bar visible on the corresponding edge, in which case it will return
* the scroller <div> itself.
*
+ * @return {{horizontal: boolean, vertical:boolean}}
* @private
*/
browserTest.Scrollbars.prototype.getScrollbarState_ = function() {
@@ -145,6 +147,9 @@ browserTest.Scrollbars.prototype.getScrollbarState_ = function() {
* Returns a promise that resolves if the scroll-bar state is as expected, or
* rejects otherwise.
*
+ * @param {boolean} horizontalExpected
+ * @param {boolean} verticalExpected
+ * @return {Promise}
* @private
*/
browserTest.Scrollbars.prototype.verifyScrollbarState_ =
@@ -168,9 +173,11 @@ browserTest.Scrollbars.prototype.verifyScrollbarState_ =
/**
- * @private
+ * @param {number} width
+ * @param {number} height
* @return {Promise} A promise that will be fulfilled when the window has
* been resized and it's safe to test scroll-bar visibility.
+ * @private
*/
browserTest.Scrollbars.prototype.resize_ = function(width, height) {
var win = chrome.app.window.current();
@@ -183,9 +190,13 @@ browserTest.Scrollbars.prototype.resize_ = function(width, height) {
/**
- * @private
+ * @param {number} width
+ * @param {number} height
+ * @param {boolean} horizontalExpected
+ * @param {boolean} verticalExpected
* @return {Promise} A promise that will be fulfilled when the window has
* been resized and it's safe to test scroll-bar visibility.
+ * @private
*/
browserTest.Scrollbars.prototype.resizeAndVerifyScroll_ =
function(width, height, horizontalExpected, verticalExpected) {
« no previous file with comments | « remoting/webapp/browser_test/mock_session_connector.js ('k') | remoting/webapp/browser_test/timeout_waiter.js » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698