Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(879)

Unified Diff: remoting/remoting_webapp.gypi

Issue 927373005: [Chromoting] Enable jscompile for browser tests. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Fix unittests; More review comments Created 5 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « remoting/remoting_test.gypi ('k') | remoting/remoting_webapp_files.gypi » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: remoting/remoting_webapp.gypi
diff --git a/remoting/remoting_webapp.gypi b/remoting/remoting_webapp.gypi
index 2c767fda205d5a96c42824850c776b6b468db66f..7d72c677e2ba83e1425d9ba9ac449661eb253d9e 100644
--- a/remoting/remoting_webapp.gypi
+++ b/remoting/remoting_webapp.gypi
@@ -23,6 +23,7 @@
['run_jscompile != 0', {
'variables': {
'success_stamp': '<(PRODUCT_DIR)/<(_target_name)_jscompile.stamp',
+ 'success_stamp_bt': '<(PRODUCT_DIR)/<(_target_name)_bt_jscompile.stamp',
},
'actions': [
{
@@ -43,6 +44,26 @@
'<@(remoting_webapp_js_proto_files)',
],
},
+ {
+ 'action_name': 'Verify remoting webapp with browsertests',
+ 'inputs': [
+ '<@(remoting_webapp_crd_js_files)',
+ '<@(remoting_webapp_browsertest_all_js_files)',
+ '<@(remoting_webapp_js_proto_files)',
+ ],
+ 'outputs': [
+ '<(success_stamp_bt)',
+ ],
+ 'action': [
+ 'python', '../third_party/closure_compiler/checker.py',
+ '--strict',
+ '--no-single-file',
+ '--success-stamp', '<(success_stamp_bt)',
+ '<@(remoting_webapp_crd_js_files)',
+ '<@(remoting_webapp_browsertest_all_js_files)',
+ '<@(remoting_webapp_js_proto_files)',
+ ],
+ },
], # actions
}],
],
« no previous file with comments | « remoting/remoting_test.gypi ('k') | remoting/remoting_webapp_files.gypi » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698