Chromium Code Reviews| Index: remoting/webapp/browser_test/scrollbar_browser_test.js |
| diff --git a/remoting/webapp/browser_test/scrollbar_browser_test.js b/remoting/webapp/browser_test/scrollbar_browser_test.js |
| index 2424c8ce5764ae2cc648213cc2e1ccd212fe290f..98ca55560c57179634b2e5aa660b2fbc4f641372 100644 |
| --- a/remoting/webapp/browser_test/scrollbar_browser_test.js |
| +++ b/remoting/webapp/browser_test/scrollbar_browser_test.js |
| @@ -53,6 +53,7 @@ browserTest.Scrollbars.prototype.run = function(data) { |
| /** |
| * Verify the test cases for the home-screen. |
| + * @return {Promise} |
|
Jamie
2015/02/18 00:51:33
Does Promise support a resolution type? In this ca
garykac
2015/02/18 02:06:49
Promise<boolean> works (as in, jscompile accepts i
|
| */ |
| browserTest.Scrollbars.prototype.verifyHomeScreenScrollbars_ = function() { |
| // Note that, due to crbug.com/240772, if the window already has |
| @@ -126,6 +127,7 @@ browserTest.Scrollbars.prototype.verifyHomeScreenScrollbars_ = function() { |
| * scroll-bar visible on the corresponding edge, in which case it will return |
| * the scroller <div> itself. |
| * |
| + * @return {{horizontal: boolean, vertical:boolean}} |
| * @private |
| */ |
| browserTest.Scrollbars.prototype.getScrollbarState_ = function() { |
| @@ -145,6 +147,9 @@ browserTest.Scrollbars.prototype.getScrollbarState_ = function() { |
| * Returns a promise that resolves if the scroll-bar state is as expected, or |
| * rejects otherwise. |
| * |
| + * @param {boolean} horizontalExpected |
| + * @param {boolean} verticalExpected |
| + * @return {Promise} |
| * @private |
| */ |
| browserTest.Scrollbars.prototype.verifyScrollbarState_ = |
| @@ -168,9 +173,11 @@ browserTest.Scrollbars.prototype.verifyScrollbarState_ = |
| /** |
| - * @private |
| + * @param {number} width |
| + * @param {number} height |
| * @return {Promise} A promise that will be fulfilled when the window has |
| * been resized and it's safe to test scroll-bar visibility. |
| + * @private |
| */ |
| browserTest.Scrollbars.prototype.resize_ = function(width, height) { |
| var win = chrome.app.window.current(); |
| @@ -183,9 +190,13 @@ browserTest.Scrollbars.prototype.resize_ = function(width, height) { |
| /** |
| - * @private |
| + * @param {number} width |
| + * @param {number} height |
| + * @param {boolean} horizontalExpected |
| + * @param {boolean} verticalExpected |
| * @return {Promise} A promise that will be fulfilled when the window has |
| * been resized and it's safe to test scroll-bar visibility. |
| + * @private |
| */ |
| browserTest.Scrollbars.prototype.resizeAndVerifyScroll_ = |
| function(width, height, horizontalExpected, verticalExpected) { |