Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2643)

Unified Diff: remoting/webapp/browser_test/mock_identity.js

Issue 927373005: [Chromoting] Enable jscompile for browser tests. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Update all_browsertest var in gyp comment Created 5 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: remoting/webapp/browser_test/mock_identity.js
diff --git a/remoting/webapp/browser_test/mock_identity.js b/remoting/webapp/browser_test/mock_identity.js
index 19f9a2b8e630cb2b164670849a2bee4d7e7fb64a..b8173915dfb04414136cec98e1049853d86eb4cf 100644
--- a/remoting/webapp/browser_test/mock_identity.js
+++ b/remoting/webapp/browser_test/mock_identity.js
@@ -67,8 +67,8 @@ remoting.MockIdentity.prototype.setAccessToken = function(accessToken) {
/**
* @param {string} token
- * @param {function()} onDone
- * @param {function()} onError
+ * @param {function(string,string)} onDone
Jamie 2015/02/18 00:51:33 This doesn't look like the right signature.
garykac 2015/02/18 02:06:49 jscompile is apparently confused by the extra para
+ * @param {function(remoting.Error):void} onError
* @param {Array.<*>} values
*/
remoting.MockIdentity.validateTokenAndCall =
@@ -85,8 +85,8 @@ remoting.MockIdentity.validateTokenAndCall =
};
/**
- * @param {function()} onDone
- * @param {function()} onError
+ * @param {function(string,string)} onDone
+ * @param {function(remoting.Error):void} onError
* @param {Array.<*>} values
*/
remoting.MockIdentity.prototype.validateTokenAndCall =

Powered by Google App Engine
This is Rietveld 408576698