[Chromoting] Enable jscompile for browser tests.

remoting/webapp/browser_test/scrollbar_browser_test.js

 // Copyright 2014 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 /**
  * @suppress {checkTypes}
  *
  * @fileoverview
  * Browser test for the scenario below:
  * 1. Resize the client window to various sizes and verify the existence of
@@ skipping 35 matching lines @@
   }
 
   // Verify that scrollbars are added/removed correctly on the home screen.
   this.verifyHomeScreenScrollbars_()
       .then(browserTest.pass, browserTest.fail);
 };
 
 
 /**
  * Verify the test cases for the home-screen.
+ * @return {Promise}

[Jamie, 2015/02/18 00:51:33]

Does Promise support a resolution type? In this case, Promise.<boolean> would be
appropriate, I think.

[garykac, 2015/02/18 02:06:49]

Promise<boolean> works (as in, jscompile accepts it), but it also accepts
Promise<string> and Promise<number> here without complaining, so it doesn't seem
to provide any value.

  */
 browserTest.Scrollbars.prototype.verifyHomeScreenScrollbars_ = function() {
   // Note that, due to crbug.com/240772, if the window already has
   // scroll-bars, they will not be removed if the window size is
   // increased by less than the scroll-bar width. We work around that
   // when connected to a host because we know how big the content is
   // (in fact, testing this work-around is the main motivation for
   // writing this test), but it's not worth it for the home screen,
   // so make the window large not to require scrollbars before each test.
   var tooWide = this.CONTENT_WIDTH_ + 100;
@@ skipping 53 matching lines @@
 
 
 /**
  * Returns whether or not horizontal and vertical scroll-bars are expected
  * and visible. To do this, it performs a hit-test close to the right and
  * bottom edges of the scroller <div>; since the content of that <div> fills
  * it completely, the hit-test will return the content unless there is a
  * scroll-bar visible on the corresponding edge, in which case it will return
  * the scroller <div> itself.
  *
+ * @return {{horizontal: boolean, vertical:boolean}}
  * @private
  */
 browserTest.Scrollbars.prototype.getScrollbarState_ = function() {
   var rect = this.scroller_.getBoundingClientRect();
   var rightElement = document.elementFromPoint(
       rect.right - 1, (rect.top + rect.bottom) / 2);
   var bottomElement = document.elementFromPoint(
       (rect.left + rect.right) / 2, rect.bottom - 1);
   return {
     horizontal: bottomElement === this.scroller_,
     vertical: rightElement === this.scroller_
   };
 };
 
 
 /**
  * Returns a promise that resolves if the scroll-bar state is as expected, or
  * rejects otherwise.
  *
+ * @param {boolean} horizontalExpected
+ * @param {boolean} verticalExpected
+ * @return {Promise}
  * @private
  */
 browserTest.Scrollbars.prototype.verifyScrollbarState_ =
     function(horizontalExpected, verticalExpected) {
   var scrollbarState = this.getScrollbarState_();
   if (scrollbarState.horizontal && !horizontalExpected) {
     return Promise.reject(new Error(
         'Horizontal scrollbar present but not expected.'));
   } else if (!scrollbarState.horizontal && horizontalExpected) {
     return Promise.reject(new Error(
         'Horizontal scrollbar expected but not present.'));
   } else if (scrollbarState.vertical && !verticalExpected) {
     return Promise.reject(new Error(
         'Vertical scrollbar present but not expected.'));
   } else if (!scrollbarState.vertical && verticalExpected) {
     return Promise.reject(new Error(
         'Vertical scrollbar expected but not present.'));
   }
   return Promise.resolve();
 };
 
 
 /**
- * @private
+ * @param {number} width
+ * @param {number} height
  * @return {Promise} A promise that will be fulfilled when the window has
  *     been resized and it's safe to test scroll-bar visibility.
+ * @private
  */
 browserTest.Scrollbars.prototype.resize_ = function(width, height) {
   var win = chrome.app.window.current();
   win.resizeTo(width, height);
   // Chrome takes a while to update the scroll-bars, so don't resolve
   // immediately. Waiting for the onBoundsChanged event would be cleaner,
   // but isn't reliable.
   return base.Promise.sleep(500);
 };
 
 
 /**
- * @private
+ * @param {number} width
+ * @param {number} height
+ * @param {boolean} horizontalExpected
+ * @param {boolean} verticalExpected
  * @return {Promise} A promise that will be fulfilled when the window has
  *     been resized and it's safe to test scroll-bar visibility.
+ * @private
  */
 browserTest.Scrollbars.prototype.resizeAndVerifyScroll_ =
     function(width, height, horizontalExpected, verticalExpected) {
   return this.resize_(width, height).then(
       this.verifyScrollbarState_.bind(
           this, horizontalExpected, verticalExpected));
 };