[Chromoting] Enable jscompile for browser tests.

remoting/webapp/browser_test/mock_host_list_api.js

 // Copyright 2014 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 /**
  * @fileoverview
  * Mock implementation of remoting.HostList
  */
 
 'use strict';
@@ skipping 27 matching lines @@
       'updatedTime': new Date(1970, 1, 1).toISOString()
     }
   ];
 };
 
 /**
  * @param {function(Array.<remoting.Host>):void} onDone
  * @param {function(remoting.Error):void} onError
  */
 remoting.MockHostListApi.prototype.get = function(onDone, onError) {
-  remoting.mockIdentity.validateTokenAndCall(onDone, onError, [this.hosts]);
+  remoting.mockIdentity.validateTokenAndCall(
+      /** @type {function():void} */ (onDone),

[Jamie, 2015/02/18 00:51:33]

This doesn't look right. Is the issue simply that IIRC validateTokenAndCall can
handle arbitrary parameter lists, so the signature should be more like
function(...):void (I'm unsure of the exact syntax).

[garykac, 2015/02/18 02:06:49]

Using @type {Function} on validateTokenAndCall makes these casts unnecessary.

+      /** @type {function():void} */ (onError),

[Jamie, 2015/02/18 00:51:33]

IIRC, the error callback always has the same signature; there should be no need
to cast it.

[garykac, 2015/02/18 02:06:49]

Done.

+      [this.hosts]);
 };
 
 /**
- * @param {function():void} onDone
- * @param {function(remoting.Error):void} onError
  * @param {string} hostId
  * @param {string} hostName
  * @param {string} hostPublicKey
+ * @param {function():void} onDone
+ * @param {function(remoting.Error):void} onError
  */
 remoting.MockHostListApi.prototype.put =
     function(hostId, hostName, hostPublicKey, onDone, onError) {
   /** @type {remoting.MockHostListApi} */
   var that = this;
   var onTokenValid = function() {
     for (var i = 0; i < that.hosts.length; ++i) {
       var host = that.hosts[i];
       if (host.hostId == hostId) {
         host.hostName = hostName;
         host.hostPublicKey = hostPublicKey;
         onDone();
         return;
       }
     }
     console.error('PUT request for unknown host: ' + hostId +
                   ' (' + hostName + ')');
     onError(remoting.Error.UNEXPECTED);
   };
-  remoting.mockIdentity.validateTokenAndCall(onTokenValid, onError, []);
+  remoting.mockIdentity.validateTokenAndCall(
+      onTokenValid,
+      /** @type {function():void} */ (onError),
+      []);
 };
 
 /**
+ * @param {string} hostId
  * @param {function():void} onDone
  * @param {function(remoting.Error):void} onError
- * @param {string} hostId
  */
 remoting.MockHostListApi.prototype.remove =
     function(hostId, onDone, onError) {
   /** @type {remoting.MockHostListApi} */
   var that = this;
   var onTokenValid = function() {
     for (var i = 0; i < that.hosts.length; ++i) {
       var host = that.hosts[i];
       if (host.hostId == hostId) {
         that.hosts.splice(i, 1);
         onDone();
         return;
       }
     }
     console.error('DELETE request for unknown host: ' + hostId);
     onError(remoting.Error.UNEXPECTED);
   };
-  remoting.mockIdentity.validateTokenAndCall(onTokenValid, onError, []);
+  remoting.mockIdentity.validateTokenAndCall(
+      onTokenValid,
+      /** @type {function():void} */ (onError),
+      []);
 };
 
 /**
  * @param {boolean} active
  */
 remoting.MockHostListApi.setActive = function(active) {
   remoting.hostListApi = active ? new remoting.MockHostListApi()
                                 : new remoting.HostListApiImpl();
 };