Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(33)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 927373002: [iOS] Upstream DomAlteringLock. (Closed)

Created:
5 years, 10 months ago by droger
Modified:
5 years, 10 months ago
Reviewers:
sdefresne
CC:
chromium-reviews, Olivier
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

[iOS] Upstream DomAlteringLock. BUG=452490 Committed: https://crrev.com/88c11aa4ea457b515f6e733ec608bdf72ffe3bec Cr-Commit-Position: refs/heads/master@{#316574}

Patch Set 1 #

Total comments: 3

Patch Set 2 : Review comments #

Patch Set 3 : minor comment change #

Unified diffs Side-by-side diffs Delta from patch set Stats (+114 lines, -0 lines) Patch
A ios/chrome/browser/web/dom_altering_lock.h View 1 2 1 chunk +64 lines, -0 lines 0 comments Download
A ios/chrome/browser/web/dom_altering_lock.mm View 1 1 chunk +48 lines, -0 lines 0 comments Download
M ios/chrome/ios_chrome.gyp View 1 chunk +2 lines, -0 lines 0 comments Download

Messages

Total messages: 13 (4 generated)
droger
5 years, 10 months ago (2015-02-17 12:42:00 UTC) #2
sdefresne
https://codereview.chromium.org/927373002/diff/1/ios/chrome/browser/web/dom_altering_lock.h File ios/chrome/browser/web/dom_altering_lock.h (right): https://codereview.chromium.org/927373002/diff/1/ios/chrome/browser/web/dom_altering_lock.h#newcode33 ios/chrome/browser/web/dom_altering_lock.h:33: // |DOMAlteringLock Release| and then |completionHandler|; s/DOMAlteringLock Release/DOMAlteringLock::Release/ https://codereview.chromium.org/927373002/diff/1/ios/chrome/browser/web/dom_altering_lock.h#newcode38 ...
5 years, 10 months ago (2015-02-17 13:20:55 UTC) #3
droger
Review comments addressed.
5 years, 10 months ago (2015-02-17 13:40:44 UTC) #5
sdefresne
lgtm
5 years, 10 months ago (2015-02-17 13:47:32 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/927373002/60001
5 years, 10 months ago (2015-02-17 13:50:47 UTC) #9
commit-bot: I haz the power
Committed patchset #3 (id:60001)
5 years, 10 months ago (2015-02-17 14:10:18 UTC) #10
commit-bot: I haz the power
Patchset 3 (id:??) landed as https://crrev.com/88c11aa4ea457b515f6e733ec608bdf72ffe3bec Cr-Commit-Position: refs/heads/master@{#316574}
5 years, 10 months ago (2015-02-17 14:10:49 UTC) #11
picksi
This patch is one (of several) that has been flagged when bisecting the source of ...
5 years, 10 months ago (2015-02-19 14:01:20 UTC) #12
sdefresne
5 years, 10 months ago (2015-02-19 14:08:27 UTC) #13
Message was sent while issue was closed. 
The code is only ever build on iOS, so there is no chance that it cause a
regression on android/mac/linux/windows/chromeos.

Powered by Google App Engine
This is Rietveld 408576698