Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(327)

Issue 927363005: Work on GN Win64 build. (Closed)

Created:
5 years, 10 months ago by brettw
Modified:
5 years, 10 months ago
Reviewers:
Dirk Pranke
CC:
chromium-reviews, mlamouri+watch-content_chromium.org, chromoting-reviews_chromium.org, jam, feature-media-reviews_chromium.org, darin-cc_chromium.org, mkwst+moarreviews-renderer_chromium.org, cc-bugs_chromium.org, markusheintz_, Ken Rockot(use gerrit already)
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Work on GN Win64 build. Adds a new config to disable size_t -> int truncations and use it in various places where the x64 Windows build currently gives warnings. This covers Chrome (except for Blink which has a separate patch) and the tests. We should do a second pass to replace the existing instances of /wd4267 with this config. Committed: https://crrev.com/1deb76bc64a51808cd3df93d8166f223241487fe Cr-Commit-Position: refs/heads/master@{#316874}

Patch Set 1 #

Patch Set 2 : underscore #

Unified diffs Side-by-side diffs Delta from patch set Stats (+57 lines, -6 lines) Patch
M build/config/compiler/BUILD.gn View 1 1 chunk +14 lines, -0 lines 0 comments Download
M cc/BUILD.gn View 1 1 chunk +2 lines, -0 lines 0 comments Download
M chrome/service/BUILD.gn View 1 1 chunk +2 lines, -0 lines 0 comments Download
M components/content_settings/core/browser/BUILD.gn View 1 1 chunk +2 lines, -0 lines 0 comments Download
M components/history/core/browser/BUILD.gn View 1 1 chunk +2 lines, -0 lines 0 comments Download
M components/url_matcher/BUILD.gn View 1 1 chunk +2 lines, -0 lines 0 comments Download
M components/web_cache/browser/BUILD.gn View 1 1 chunk +2 lines, -0 lines 0 comments Download
M content/child/BUILD.gn View 1 1 chunk +4 lines, -1 line 0 comments Download
M content/common/BUILD.gn View 1 2 chunks +9 lines, -1 line 0 comments Download
M content/ppapi_plugin/broker_process_dispatcher.cc View 1 chunk +4 lines, -2 lines 0 comments Download
M content/renderer/BUILD.gn View 1 1 chunk +4 lines, -1 line 0 comments Download
M jingle/BUILD.gn View 1 1 chunk +2 lines, -0 lines 0 comments Download
M media/audio/BUILD.gn View 1 1 chunk +2 lines, -0 lines 0 comments Download
M media/base/BUILD.gn View 1 1 chunk +2 lines, -0 lines 0 comments Download
M remoting/protocol/BUILD.gn View 1 1 chunk +4 lines, -1 line 0 comments Download

Messages

Total messages: 9 (3 generated)
brettw
5 years, 10 months ago (2015-02-18 00:28:54 UTC) #2
Dirk Pranke
lgtm. +rockot, who was hitting this exact thing on a patch earlier today and to ...
5 years, 10 months ago (2015-02-18 01:31:17 UTC) #3
brettw
Okay, I was on the fence about the underscore so I added it.
5 years, 10 months ago (2015-02-18 17:40:31 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/927363005/20001
5 years, 10 months ago (2015-02-18 17:41:49 UTC) #7
commit-bot: I haz the power
Committed patchset #2 (id:20001)
5 years, 10 months ago (2015-02-18 19:28:36 UTC) #8
commit-bot: I haz the power
5 years, 10 months ago (2015-02-18 19:29:35 UTC) #9
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/1deb76bc64a51808cd3df93d8166f223241487fe
Cr-Commit-Position: refs/heads/master@{#316874}

Powered by Google App Engine
This is Rietveld 408576698