runtime/vm/simulator_arm.cc - Issue 927363004: Verify/document assumption about stack resource addresses.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: runtime/vm/simulator_arm.cc

Issue 927363004: Verify/document assumption about stack resource addresses. (Closed) Base URL: http://dart.googlecode.com/svn/branches/bleeding_edge/dart/

Patch Set: Created 5 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: runtime/vm/simulator_arm.cc

===================================================================

--- runtime/vm/simulator_arm.cc (revision 43776)

+++ runtime/vm/simulator_arm.cc (working copy)

@@ -3860,10 +3860,7 @@

// Prepare for unwinding frames by destroying all the stack resources

// in the previous C++ frames.

uword native_sp = buf->native_sp();

- while (isolate->top_resource() != NULL &&

- (reinterpret_cast<uword>(isolate->top_resource()) < native_sp)) {

- isolate->top_resource()->~StackResource();

- }

+ StackResource::Unwind(isolate, native_sp);

// Unwind the C++ stack and continue simulation in the target frame.

set_register(PC, static_cast<int32_t>(pc));

« no previous file with comments | « runtime/vm/longjump.cc ('k') | runtime/vm/simulator_arm64.cc » ('j') | no next file with comments »