Add [TypeChecking=Unrestricted] to Web Audio interfaces

Source/modules/webaudio/AudioParamTimeline.cpp

 /*
  * Copyright (C) 2011 Google Inc. All rights reserved.
  *
  * Redistribution and use in source and binary forms, with or without
  * modification, are permitted provided that the following conditions
  * are met:
  *
  * 1.  Redistributions of source code must retain the above copyright
  *     notice, this list of conditions and the following disclaimer.
  * 2.  Redistributions in binary form must reproduce the above copyright
@@ skipping 20 matching lines @@
 
 #include "bindings/core/v8/ExceptionState.h"
 #include "core/dom/ExceptionCode.h"
 #include "platform/audio/AudioUtilities.h"
 #include "platform/FloatConversion.h"
 #include "wtf/MathExtras.h"
 #include <algorithm>
 
 namespace blink {
 
-static bool isValidAudioParamValue(float value, ExceptionState& exceptionState)
+static bool isPositiveAudioParamValue(float value, ExceptionState& exceptionState)
 {
-    if (std::isfinite(value))
+    if (value > 0)
         return true;
 
     exceptionState.throwDOMException(
-        InvalidAccessError,
-        "Target value must be a finite number: " + String::number(value));
-    return false;
-}
-
-static bool isPositiveAudioParamValue(float value, ExceptionState& exceptionState)
-{
-    if (std::isfinite(value) && (value > 0))
-        return true;
-
-    exceptionState.throwDOMException(
         InvalidAccessError,
         "Target value must be a finite positive number: " + String::number(value));
     return false;
 }
 
-static bool isValidAudioParamTime(double time, ExceptionState& exceptionState, String message)
+static bool isNonNegativeAudioParamTime(double time, ExceptionState& exceptionState, String message = "Time")
 {
-    if (std::isfinite(time) && (time >= 0))
+    if (time >= 0)
         return true;
 
     exceptionState.throwDOMException(
         InvalidAccessError,
         message + " must be a finite non-negative number: " + String::number(time));
     return false;
 }
 
 static bool isPositiveAudioParamTime(double time, ExceptionState& exceptionState, String message)
 {
-    if (std::isfinite(time) && (time > 0))
+    if (time > 0)
         return true;
 
     exceptionState.throwDOMException(
         InvalidAccessError,
         message + " must be a finite positive number: " + String::number(time));
     return false;
 }
 
-static bool isValidAudioParamTime(double time, ExceptionState& exceptionState)
-{
-    return isValidAudioParamTime(time, exceptionState, "Time");
-}
-
 void AudioParamTimeline::setValueAtTime(float value, double time, ExceptionState& exceptionState)
 {
     ASSERT(isMainThread());
 
-    if (!isValidAudioParamValue(value, exceptionState)
-        || !isValidAudioParamTime(time, exceptionState))
+    if (!isNonNegativeAudioParamTime(time, exceptionState))
         return;
 
     insertEvent(ParamEvent(ParamEvent::SetValue, value, time, 0, 0, nullptr));
 }
 
 void AudioParamTimeline::linearRampToValueAtTime(float value, double time, ExceptionState& exceptionState)
 {
     ASSERT(isMainThread());
 
-    if (!isValidAudioParamValue(value, exceptionState)
-        || !isValidAudioParamTime(time, exceptionState))
+    if (!isNonNegativeAudioParamTime(time, exceptionState))
         return;
 
     insertEvent(ParamEvent(ParamEvent::LinearRampToValue, value, time, 0, 0, nullptr));
 }
 
 void AudioParamTimeline::exponentialRampToValueAtTime(float value, double time, ExceptionState& exceptionState)
 {
     ASSERT(isMainThread());
 
     if (!isPositiveAudioParamValue(value, exceptionState)
-        || !isValidAudioParamTime(time, exceptionState))
+        || !isNonNegativeAudioParamTime(time, exceptionState))
         return;
 
     insertEvent(ParamEvent(ParamEvent::ExponentialRampToValue, value, time, 0, 0, nullptr));
 }
 
 void AudioParamTimeline::setTargetAtTime(float target, double time, double timeConstant, ExceptionState& exceptionState)
 {
     ASSERT(isMainThread());
 
-    if (!isValidAudioParamValue(target, exceptionState)
-        || !isValidAudioParamTime(time, exceptionState)
-        || !isValidAudioParamTime(timeConstant, exceptionState, "Time constant"))
+    if (!isNonNegativeAudioParamTime(time, exceptionState)
+        || !isNonNegativeAudioParamTime(timeConstant, exceptionState, "Time constant"))
         return;
 
     insertEvent(ParamEvent(ParamEvent::SetTarget, target, time, timeConstant, 0, nullptr));
 }
 
 void AudioParamTimeline::setValueCurveAtTime(DOMFloat32Array* curve, double time, double duration, ExceptionState& exceptionState)
 {
     ASSERT(isMainThread());
 
-    if (!isValidAudioParamTime(time, exceptionState)
+    if (!isNonNegativeAudioParamTime(time, exceptionState)
         || !isPositiveAudioParamTime(duration, exceptionState, "Duration"))
         return;
 
     insertEvent(ParamEvent(ParamEvent::SetValueCurve, 0, time, 0, duration, curve));
 }
 
 void AudioParamTimeline::insertEvent(const ParamEvent& event)
 {
     // Sanity check the event. Be super careful we're not getting infected with NaN or Inf. These
     // should have been handled by the caller.
@@ skipping 23 matching lines @@
             break;
     }
 
     m_events.insert(i, event);
 }
 
 void AudioParamTimeline::cancelScheduledValues(double startTime, ExceptionState& exceptionState)
 {
     ASSERT(isMainThread());
 
-    if (!std::isfinite(startTime)) {
-        exceptionState.throwDOMException(
-            InvalidStateError,
-            "Time must be a finite number: " + String::number(startTime));
-    }
-
     MutexLocker locker(m_eventsLock);
 
     // Remove all events starting at startTime.
     for (unsigned i = 0; i < m_events.size(); ++i) {
         if (m_events[i].time() >= startTime) {
             m_events.remove(i, m_events.size() - i);
             break;
         }
     }
 }
@@ skipping 249 matching lines @@
     // to the end of the values buffer.
     for (; writeIndex < numberOfValues; ++writeIndex)
         values[writeIndex] = value;
 
     return value;
 }
 
 } // namespace blink
 
 #endif // ENABLE(WEB_AUDIO)