Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(15)

Issue 927333002: Fix closure compiler error which is introduced by 931103002. (Closed)

Created:
5 years, 10 months ago by yawano
Modified:
5 years, 10 months ago
Reviewers:
fukino
CC:
chromium-reviews, rginda+watch_chromium.org, mtomasz+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Fix closure compiler error which is introduced by 931103002. BUG=456016 TEST=GYP_GENERATORS=ninja tools/gyp/gyp --depth . ui/file_manager/file_manager/foreground/js/compiled_resources.gyp && ninja -C out/Default Committed: https://crrev.com/137699b20cabc84d7ca66e17ed25fce62c4009ff Cr-Commit-Position: refs/heads/master@{#316561}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M ui/file_manager/file_manager/foreground/js/ui/file_grid.js View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 8 (2 generated)
yawano
My CL broke closure compiler bot. PTAL. Thank you!
5 years, 10 months ago (2015-02-17 10:34:32 UTC) #2
fukino
On 2015/02/17 10:34:32, yawano wrote: > My CL broke closure compiler bot. PTAL. Thank you! ...
5 years, 10 months ago (2015-02-17 10:47:41 UTC) #3
yawano
On 2015/02/17 10:47:41, fukino wrote: > On 2015/02/17 10:34:32, yawano wrote: > > My CL ...
5 years, 10 months ago (2015-02-17 11:03:27 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/927333002/1
5 years, 10 months ago (2015-02-17 11:04:28 UTC) #6
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 10 months ago (2015-02-17 11:30:00 UTC) #7
commit-bot: I haz the power
5 years, 10 months ago (2015-02-17 11:30:37 UTC) #8
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/137699b20cabc84d7ca66e17ed25fce62c4009ff
Cr-Commit-Position: refs/heads/master@{#316561}

Powered by Google App Engine
This is Rietveld 408576698