Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(55)

Issue 927323002: Add TypeChecking=Unrestricted to DataView (Closed)

Created:
5 years, 10 months ago by fs
Modified:
5 years, 10 months ago
Reviewers:
haraken, Jens Widell, Yuki
CC:
blink-reviews, blink-reviews-dom_chromium.org, arv+blink, vivekg_samsung, sof, eae+blinkwatch, vivekg, dglazkov+blink, Inactive, rwlbuis
Target Ref:
refs/heads/master
Project:
blink
Visibility:
Public.

Description

Add TypeChecking=Unrestricted to DataView This may be mostly for show, but it at the very least documents behavior and intent. Also drop comment referring to JSC since that no longer applies. BUG=354298 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=190313

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -4 lines) Patch
M Source/core/dom/DataView.idl View 3 chunks +3 lines, -4 lines 0 comments Download

Messages

Total messages: 11 (3 generated)
fs
5 years, 10 months ago (2015-02-17 11:25:22 UTC) #2
haraken
LGTM
5 years, 10 months ago (2015-02-17 12:33:48 UTC) #4
Jens Widell
Note that the contents of this interface definition has no effect on generated code. You ...
5 years, 10 months ago (2015-02-17 12:37:36 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/927323002/1
5 years, 10 months ago (2015-02-17 12:37:36 UTC) #7
Yuki
lgtm
5 years, 10 months ago (2015-02-17 12:41:21 UTC) #8
commit-bot: I haz the power
Committed patchset #1 (id:1) as https://src.chromium.org/viewvc/blink?view=rev&revision=190313
5 years, 10 months ago (2015-02-17 12:41:25 UTC) #9
fs
On 2015/02/17 12:37:36, Jens Widell wrote: > Note that the contents of this interface definition ...
5 years, 10 months ago (2015-02-17 12:43:00 UTC) #10
Jens Widell
5 years, 10 months ago (2015-02-17 12:44:19 UTC) #11
Message was sent while issue was closed.
On 2015/02/17 12:43:00, fs wrote:
> On 2015/02/17 12:37:36, Jens Widell wrote:
> > Note that the contents of this interface definition has no effect on
generated
> > code. You can delete all the methods if you like. :-)
> 
> Yeah I noticed... hence the "mostly for show" (entirely might have been better
> there...).

It will remove it from my list of incorrectly unrestricted floats, and that's
good. :-)

Powered by Google App Engine
This is Rietveld 408576698