chrome/browser/resources/chromeos/chromevox/braille/braille_translator_manager.js - Issue 927313002: Fix and reenable liblouis chromevox tests.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/resources/chromeos/chromevox/braille/braille_translator_manager.js

Issue 927313002: Fix and reenable liblouis chromevox tests. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@test_api

Patch Set: Fix BrailleTranslatorManager tests that broke when fetchTables was moved into the event handler. Created 5 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: chrome/browser/resources/chromeos/chromevox/braille/braille_translator_manager.js

diff --git a/chrome/browser/resources/chromeos/chromevox/braille/braille_translator_manager.js b/chrome/browser/resources/chromeos/chromevox/braille/braille_translator_manager.js

index 500c5b3f09fac4001c2e7bbb6bcd3484455bca54..2a152b228372ae2e03701b77057e5dd1556c14f2 100644

--- a/chrome/browser/resources/chromeos/chromevox/braille/braille_translator_manager.js

+++ b/chrome/browser/resources/chromeos/chromevox/braille/braille_translator_manager.js

@@ -61,9 +61,11 @@ cvox.BrailleTranslatorManager = function(opt_liblouisForTest) {

this.uncontractedTableId_ = null;

- this.fetchTables_();

- document.addEventListener('DOMContentLoaded', this.loadLiblouis_.bind(this),

- false);

+ if (!opt_liblouisForTest) {

+ document.addEventListener('DOMContentLoaded',

+ this.loadLiblouis_.bind(this),

+ false);

+ }

};

cvox.BrailleTranslatorManager.prototype = {

@@ -211,6 +213,7 @@ cvox.BrailleTranslatorManager.prototype = {

// have a body.

this.liblouis_.attachToElement(

/** @type {!HTMLBodyElement} */ (document.body));

+ this.fetchTables_();

/**

« no previous file with comments | « no previous file | chrome/browser/resources/chromeos/chromevox/braille/braille_translator_manager_test.extjs » ('j') | no next file with comments »