Fix and reenable liblouis chromevox tests.

chrome/browser/resources/chromeos/chromevox/braille/liblouis_test.extjs

 // Copyright 2014 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 /**
  * @fileoverview Tests for the liblouis Native Client wrapper, as seen from
  *    the JavaScript interface.
  */
 
 // Include test fixture.
@@ skipping 12 matching lines @@
   createLiblouis: function() {
     return new cvox.LibLouis(
         chrome.extension.getURL('braille/liblouis_nacl.nmf'),
         chrome.extension.getURL('braille/tables'));
   },
 
   createAndAttachLiblouis: function() {
     var liblouis = this.createLiblouis();
     liblouis.attachToElement(document.body);
     return liblouis;
-  }
+  },
+
+  withTranslator: function(liblouis, tableNames, callback) {
+    liblouis.getTranslator(tableNames,
+                           this.continueTest(WhenTestDone.ASSERT, callback));
+  },
 };
 
 function assertEqualsUint8Array(expected, actual) {
   var as_array = [];
   var uint8array = new Uint8Array(actual);
   for (var i = 0; i < uint8array.length; ++i) {
     as_array[i] = uint8array[i];
   }
   assertEqualsJSON(expected, as_array);
 }
 
-// Disable all of tests because they are flaky.  crbug.com/458643
-
-TEST_F('CvoxLibLouisTest', 'DISABLED_checkAllTables', function() {
+TEST_F('CvoxLibLouisTest', 'checkAllTables', function() {
   var liblouis = this.createAndAttachLiblouis();
-  cvox.BrailleTable.getAll(function(allTables) {
+  var continuation = this.continueTest(WhenTestDone.ASSERT, function(tables) {
     var i = 0;
     var checkNextTable = function() {
-      var table = allTables[i++];
+      var table = tables[i++];
       if (table) {
-        liblouis.getTranslator(table.fileNames, function(translator) {
+        this.withTranslator(liblouis, table.fileNames, function(translator) {
           assertNotEquals(null, translator,
                              'Table ' + table + ' should be valid');
           checkNextTable();
         });
       } else {
         testDone();
       }
-    };
+    }.bind(this);
     checkNextTable();
+  }.bind(this));
+  cvox.BrailleTable.getAll(continuation);
+});
+
+TEST_F('CvoxLibLouisTest', 'testTranslateComputerBraille', function() {
+  var liblouis = this.createAndAttachLiblouis();
+  this.withTranslator(liblouis, 'en-us-comp8.ctb', function(translator) {
+    var continuation = this.continueTest(
+        WhenTestDone.ALWAYS,
+        function(cells, textToBraille, brailleToText) {
+          assertEqualsUint8Array([0x53, 0x11, 0x07, 0x07, 0x15, 0x2e], cells);
+          assertEqualsJSON([0, 1, 2, 3, 4, 5], textToBraille);
+          assertEqualsJSON([0, 1, 2, 3, 4, 5], brailleToText);
+        });
+    translator.translate('Hello!', continuation);
   });
 });
 
-TEST_F('CvoxLibLouisTest', 'DISABLED_testTranslateComputerBraille', function () {
+TEST_F('CvoxLibLouisTest', 'testBackTranslateComputerBraille', function() {
   var liblouis = this.createAndAttachLiblouis();
-  liblouis.getTranslator('en-us-comp8.ctb', function(translator) {
-    translator.translate(
-        'Hello!', function(cells, textToBraille, brailleToText) {
-          assertEqualsUint8Array([0x53, 0x11, 0x07, 0x07, 0x15, 0x2e], cells);
-          assertEqualsJSON([0, 1, 2, 3, 4, 5], textToBraille);
-          assertEqualsJSON([0, 1, 2, 3, 4, 5], brailleToText);
-          testDone();
-        });
+  this.withTranslator(liblouis, 'en-us-comp8.ctb', function(translator) {
+    var cells = new Uint8Array([0x53, 0x11, 0x07, 0x07, 0x15, 0x2e]);
+    var continuation = this.continueTest(WhenTestDone.ALWAYS, function(text) {
+      assertEquals('Hello!', text);
+    });
+    translator.backTranslate(cells.buffer, continuation);
   });
 });
 
-TEST_F('CvoxLibLouisTest', 'DISABLED_testBackTranslateComputerBraille', function() {
+TEST_F('CvoxLibLouisTest', 'testTranslateGermanGrade2Braille', function() {
   var liblouis = this.createAndAttachLiblouis();
-  liblouis.getTranslator('en-us-comp8.ctb', function(translator) {
-    var cells = new Uint8Array([0x53, 0x11, 0x07, 0x07, 0x15, 0x2e]);
-    translator.backTranslate(cells.buffer, function(text) {
-      assertEquals('Hello!', text);
-      testDone();
-    });
+  // This is one of the moderately large tables.
+  this.withTranslator(liblouis, 'de-de-g2.ctb', function(translator) {
+    var continuation = this.continueTest(
+        WhenTestDone.ALWAYS, function(cells, textToBraille, brailleToText) {
+          assertEqualsUint8Array([0x0d, 0x33, 0x1d, 0x39, 0x09], cells);
+          assertEqualsJSON([0, 1, 2, 3, 3, 4, 4], textToBraille);
+          assertEqualsJSON([0, 1, 2, 3, 5], brailleToText);
+        });
+    translator.translate('München', continuation);
   });
 });
 
-TEST_F('CvoxLibLouisTest', 'DISABLED_testTranslateGermanGrade2Braille', function() {
+TEST_F('CvoxLibLouisTest', 'testBackTranslateGermanComputerBraille', function() {
   var liblouis = this.createAndAttachLiblouis();
-  // This is one of the moderately large tables.
-  liblouis.getTranslator('de-de-g2.ctb', function(translator) {
-    translator.translate(
-         'München', function(cells, textToBraille, brailleToText) {
-           assertEqualsUint8Array([0x0d, 0x33, 0x1d, 0x39, 0x09], cells);
-           assertEqualsJSON([0, 1, 2, 3, 3, 4, 4], textToBraille);
-           assertEqualsJSON([0, 1, 2, 3, 5], brailleToText);
-           testDone();
-         });
+  this.withTranslator(liblouis, 'de-de-comp8.ctb', function(translator) {
+    var cells = new Uint8Array([0xb3]);
+    var continuation = this.continueTest(WhenTestDone.ALWAYS, function(text) {
+      assertEquals('ü', text);
+    });
+    translator.backTranslate(cells.buffer, continuation);
   });
 });
 
-TEST_F('CvoxLibLouisTest', 'DISABLED_testBackTranslateGermanComputerBraille', function() {
+TEST_F('CvoxLibLouisTest', 'testBackTranslateEmptyCells', function() {
   var liblouis = this.createAndAttachLiblouis();
-  liblouis.getTranslator('de-de-comp8.ctb', function(translator) {
-    var cells = new Uint8Array([0xb3]);
-    translator.backTranslate(cells.buffer, function(text) {
-      assertEquals('ü', text);
-      testDone();
+  this.withTranslator(liblouis, 'de-de-comp8.ctb', function(translator) {
+    var continuation = this.continueTest(WhenTestDone.ALWAYS, function(text) {
+      assertNotEquals(null, text);
+      assertEquals(0, text.length);
     });
+    translator.backTranslate(new Uint8Array().buffer, continuation);
   });
 });
 
-TEST_F('CvoxLibLouisTest', 'DISABLED_testBackTranslateEmptyCells', function() {
-  var liblouis = this.createAndAttachLiblouis();
-  liblouis.getTranslator('de-de-comp8.ctb', function(translator) {
-    var cells = new Uint8Array();
-    translator.backTranslate(cells.buffer, function(text) {
-      assertNotEquals(null, text);
-      assertEquals(0, text.length);
-      testDone();
-    });
-  });
-});
-
-TEST_F('CvoxLibLouisTest', 'DISABLED_testGetTranslatorBeforeAttach', function() {
+TEST_F('CvoxLibLouisTest', 'testGetTranslatorBeforeAttach', function() {
   var liblouis = this.createLiblouis();
   assertFalse(liblouis.isAttached());
-  liblouis.getTranslator('en-us-comp8.ctb', function(translator) {
-    assertNotEquals(null, translator);
-    testDone();
-  });
-  liblouis.attachToElement(document.body);
-});
-
-TEST_F('CvoxLibLouisTest', 'DISABLED_testGetInvalidTranslator', function() {
-  var liblouis = this.createAndAttachLiblouis();
-  liblouis.getTranslator('nonexistant-table', function(translator) {
+  this.withTranslator(liblouis, 'en-us-comp8.ctb', function(translator) {
     assertEquals(null, translator);
     testDone();
   });
 });
+
+TEST_F('CvoxLibLouisTest', 'testGetInvalidTranslator', function() {
+  var liblouis = this.createAndAttachLiblouis();
+  this.withTranslator(liblouis, 'nonexistant-table', function(translator) {
+    assertEquals(null, translator);
+    testDone();
+  });
+});
+
+TEST_F('CvoxLibLouisTest', 'testTranslateAfterDetach', function() {
+  var liblouis = this.createAndAttachLiblouis();
+  this.withTranslator(liblouis, 'de-de-comp8.ctb', function(translator) {
+    liblouis.detach();
+    var continuation = this.continueTest(
+        WhenTestDone.ALWAYS,
+        function(cells, textToBraille, brailleToText) {
+          assertEquals(null, cells);
+          assertEquals(null, textToBraille);
+          assertEquals(null, brailleToText);
+        });
+    translator.translate('Hamburg', continuation);
+  });
+});
+
+TEST_F('CvoxLibLouisTest', 'testDetachWithOutstandingCallbacks', function() {
+  var liblouis = this.createAndAttachLiblouis();
+  this.withTranslator(liblouis, 'de-de-comp8.ctb', function(translator) {
+    var continuation = this.continueTest(
+        WhenTestDone.ALWAYS,
+        function(cells, textToBraille, brailleToText) {
+          assertEquals(null, cells);
+          assertEquals(null, textToBraille);
+          assertEquals(null, brailleToText);
+        });
+    translator.translate('Berlin', continuation);
+    liblouis.detach();
+  });
+});