chrome/browser/extensions/api/platform_keys/platform_keys_apitest_nss.cc - Issue 927293002: platformKeys: Hook up the certificate selection dialog to selectClientCertificates.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/extensions/api/platform_keys/platform_keys_apitest_nss.cc

Issue 927293002: platformKeys: Hook up the certificate selection dialog to selectClientCertificates. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@cert_perms

Patch Set: Addressed Bartosz's and Mike's comments. Created 5 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« chrome/browser/chromeos/platform_keys/platform_keys_service_factory.cc ('K') | « chrome/browser/extensions/api/platform_keys/platform_keys_api.cc ('k') | chrome/browser/ui/platform_keys_certificate_selector_chromeos.h » ('j') | chrome/browser/ui/views/platform_keys_certificate_selector_chromeos.h » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/extensions/api/platform_keys/platform_keys_apitest_nss.cc

diff --git a/chrome/browser/extensions/api/platform_keys/platform_keys_apitest_nss.cc b/chrome/browser/extensions/api/platform_keys/platform_keys_apitest_nss.cc

index 2788cd9ca1c749746db12ca5a6c186c0f3f66217..2c51e27bdbd792b48ea074f6009ad5cfc3842fbe 100644

--- a/chrome/browser/extensions/api/platform_keys/platform_keys_apitest_nss.cc

+++ b/chrome/browser/extensions/api/platform_keys/platform_keys_apitest_nss.cc

@@ -192,7 +192,11 @@ class TestSelectDelegate

void Select(const std::string& extension_id,

const net::CertificateList& certs,

- const CertificateSelectedCallback& callback) override {

+ const CertificateSelectedCallback& callback,

+ content::WebContents* web_contents,

+ content::BrowserContext* context) override {

+ ASSERT_TRUE(web_contents);

+ ASSERT_TRUE(context);

if (!cert_to_select_) {

callback.Run(nullptr /* no cert */);

return;