OLD | NEW |
---|---|
(Empty) | |
1 // Copyright 2015 The Chromium Authors. All rights reserved. | |
2 // Use of this source code is governed by a BSD-style license that can be | |
3 // found in the LICENSE file. | |
4 | |
5 #ifndef CHROME_BROWSER_UI_VIEWS_PLATFORM_KEYS_CERTIFICATE_SELECTOR_CHROMEOS_H_ | |
6 #define CHROME_BROWSER_UI_VIEWS_PLATFORM_KEYS_CERTIFICATE_SELECTOR_CHROMEOS_H_ | |
7 | |
8 #include <string> | |
9 | |
10 #include "base/callback_forward.h" | |
11 #include "base/macros.h" | |
12 #include "base/memory/ref_counted.h" | |
13 #include "chrome/browser/ui/views/certificate_selector.h" | |
14 | |
15 namespace content { | |
16 class WebContents; | |
17 } | |
18 | |
19 namespace net { | |
20 class X509Certificate; | |
21 } | |
22 | |
23 namespace chromeos { | |
24 | |
25 class PlatformKeysCertificateSelector : public chrome::CertificateSelector { | |
msw
2015/02/19 20:21:54
Add a class comment, consider adding a warning tha
pneubeck (no reviews)
2015/02/19 21:51:41
considering the DEPS rules that should be impossib
| |
26 public: | |
27 using CertificateSelectedCallback = base::Callback<void( | |
bartfab (slow)
2015/02/19 18:55:42
Nit: You keep redefinining this type. Would it not
pneubeck (no reviews)
2015/02/19 21:51:41
Done.
| |
28 const scoped_refptr<net::X509Certificate>& selection)>; | |
29 | |
30 PlatformKeysCertificateSelector(const net::CertificateList& certificates, | |
bartfab (slow)
2015/02/19 18:55:43
Nit: Forward-declare |net::CertificateList|.
pneubeck (no reviews)
2015/02/19 21:51:41
Following another comment of Mike, including x509_
| |
31 const std::string& extension_name, | |
32 const CertificateSelectedCallback& callback, | |
33 content::WebContents* web_contents); | |
34 ~PlatformKeysCertificateSelector() override; | |
35 | |
36 void Init(); | |
msw
2015/02/19 20:21:54
nit: try to avoid overloading this name with the b
pneubeck (no reviews)
2015/02/19 21:51:41
Done.
| |
37 | |
38 // chrome::CertificateSelector: | |
39 bool Cancel() override; | |
40 bool Accept() override; | |
41 | |
42 private: | |
43 const std::string extension_name_; | |
44 const CertificateSelectedCallback callback_; | |
bartfab (slow)
2015/02/19 18:55:43
Nit: You need base/callback.h instead of base/call
pneubeck (no reviews)
2015/02/19 21:51:41
Done.
| |
45 | |
46 DISALLOW_COPY_AND_ASSIGN(PlatformKeysCertificateSelector); | |
47 }; | |
48 | |
49 } // namespace chromeos | |
50 | |
51 #endif // CHROME_BROWSER_UI_VIEWS_PLATFORM_KEYS_CERTIFICATE_SELECTOR_CHROMEOS_H _ | |
OLD | NEW |