platformKeys: Hook up the certificate selection dialog to selectClientCertificates.

chrome/browser/ui/views/platform_keys_certificate_selector_chromeos.h

+// Copyright 2015 The Chromium Authors. All rights reserved.
+// Use of this source code is governed by a BSD-style license that can be
+// found in the LICENSE file.
+
+#ifndef CHROME_BROWSER_UI_VIEWS_PLATFORM_KEYS_CERTIFICATE_SELECTOR_CHROMEOS_H_
+#define CHROME_BROWSER_UI_VIEWS_PLATFORM_KEYS_CERTIFICATE_SELECTOR_CHROMEOS_H_
+
+#include <string>
+
+#include "base/callback_forward.h"
+#include "base/macros.h"
+#include "base/memory/ref_counted.h"
+#include "chrome/browser/ui/views/certificate_selector.h"
+
+namespace content {
+class WebContents;
+}
+
+namespace net {
+class X509Certificate;
+}
+
+namespace chromeos {
+
+class PlatformKeysCertificateSelector : public chrome::CertificateSelector {

[msw, 2015/02/19 20:21:54]

Add a class comment, consider adding a warning that users should use
browser/ui/platform_keys_certificate_selector_chromeos.h instead of using this
class/header, similar to the comment in ssl_client_certificate_selector.h

[pneubeck (no reviews), 2015/02/19 21:51:41]

considering the DEPS rules that should be impossible.
to be safe and for documenting how to actually use this class, I added the
comment.

+ public:
+  using CertificateSelectedCallback = base::Callback<void(

[bartfab (slow), 2015/02/19 18:55:42]

Nit: You keep redefinining this type. Would it not have been possible to define
it once and for all in a header?

[pneubeck (no reviews), 2015/02/19 21:51:41]

Done.

+      const scoped_refptr<net::X509Certificate>& selection)>;
+
+  PlatformKeysCertificateSelector(const net::CertificateList& certificates,

[bartfab (slow), 2015/02/19 18:55:43]

Nit: Forward-declare |net::CertificateList|.

[pneubeck (no reviews), 2015/02/19 21:51:41]

Following another comment of Mike, including x509_certificate.h

+                                  const std::string& extension_name,
+                                  const CertificateSelectedCallback& callback,
+                                  content::WebContents* web_contents);
+  ~PlatformKeysCertificateSelector() override;
+
+  void Init();

[msw, 2015/02/19 20:21:54]

nit: try to avoid overloading this name with the base class.

[pneubeck (no reviews), 2015/02/19 21:51:41]

Done.

+
+  // chrome::CertificateSelector:
+  bool Cancel() override;
+  bool Accept() override;
+
+ private:
+  const std::string extension_name_;
+  const CertificateSelectedCallback callback_;

[bartfab (slow), 2015/02/19 18:55:43]

Nit: You need base/callback.h instead of base/callback_forward.h for this.

[pneubeck (no reviews), 2015/02/19 21:51:41]

Done.

+
+  DISALLOW_COPY_AND_ASSIGN(PlatformKeysCertificateSelector);
+};
+
+}  // namespace chromeos
+
+#endif  // CHROME_BROWSER_UI_VIEWS_PLATFORM_KEYS_CERTIFICATE_SELECTOR_CHROMEOS_H_