Tidy up JS_Defines.h

Tidy up JS_Defines.h

This is a purely mechanical change, no new functionality.

- Expand some macros which were merely a short-cut to save
  typing but reduced transparency.

- Put GET_VALUE_TYPE() implementation into a .cpp file.

This is a portion of the patch from issue 908033002 at
patchset 40001 (http://crrev.com/908033002#ps40001)

R=brucedawson@chromium.org

Committed: https://pdfium.googlesource.com/pdfium/+/2da7bd4d78897bed52fe1304694f4e970db65e58

[Tom Sepez, 2015-02-17 20:21:18]

tsepez@chromium.org changed reviewers:
+ brucedawson@chromium.org, thestig@chromium.org

[Tom Sepez, 2015-02-17 20:21:55]

On 2015/02/17 20:21:18, Tom Sepez wrote:
> mailto:tsepez@chromium.org changed reviewers:
> + mailto:brucedawson@chromium.org, mailto:thestig@chromium.org
Bruce, Lei, please review.  This is the first half of the larger change that you
requested be performed separately.

[brucedawson, 2015-02-17 21:08:02]

lgtm

https://codereview.chromium.org/927263003/diff/1/fpdfsdk/include/javascript/J...
File fpdfsdk/include/javascript/JS_Define.h (left):

https://codereview.chromium.org/927263003/diff/1/fpdfsdk/include/javascript/J...
fpdfsdk/include/javascript/JS_Define.h:660: static FXJSVALUETYPE
GET_VALUE_TYPE(v8::Handle<v8::Value> p)
I wonder why GET_VALUE_TYPE was defined as static in a header file. Very
strange.

[Tom Sepez, 2015-02-17 21:21:41]

Committed patchset #1 (id:1) manually as
2da7bd4d78897bed52fe1304694f4e970db65e58 (presubmit successful).