Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(559)

Unified Diff: ui/views/widget/widget_unittest.cc

Issue 927233003: MacViews: Fix positioning of top-level Widgets with parents (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@20150129-MacViews-Bringup5
Patch Set: Added comment to BridgedNativeWidget Created 5 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « ui/views/widget/native_widget_mac.mm ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: ui/views/widget/widget_unittest.cc
diff --git a/ui/views/widget/widget_unittest.cc b/ui/views/widget/widget_unittest.cc
index 7c739d2b758ac66cc330a4ed45bc102a1c25bc1f..083642169627ac2317ad9599d518572de5afe1aa 100644
--- a/ui/views/widget/widget_unittest.cc
+++ b/ui/views/widget/widget_unittest.cc
@@ -1005,8 +1005,11 @@ TEST_F(WidgetObserverTest, WidgetBoundsChangedNative) {
EXPECT_FALSE(widget_bounds_changed());
- // Init causes a bounds change, even while not showing.
- widget->Init(CreateParams(Widget::InitParams::TYPE_WINDOW));
+ // Init causes a bounds change, even while not showing. Note some platforms
+ // cause a bounds change even when the bounds are empty. Mac does not.
+ Widget::InitParams params = CreateParams(Widget::InitParams::TYPE_WINDOW);
+ params.bounds = gfx::Rect(0, 0, 100, 100);
+ widget->Init(params);
EXPECT_TRUE(widget_bounds_changed());
reset();
« no previous file with comments | « ui/views/widget/native_widget_mac.mm ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698