build/android/pylib/monkey/test_runner.py - Issue 92723002: [Android] Make exceptions when starting MinidumpUploadService non-fatal.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: build/android/pylib/monkey/test_runner.py

Issue 92723002: [Android] Make exceptions when starting MinidumpUploadService non-fatal. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: Created 7 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: build/android/pylib/monkey/test_runner.py

diff --git a/build/android/pylib/monkey/test_runner.py b/build/android/pylib/monkey/test_runner.py

index 1920464547fa4882869db0bfb03a053d76506133..d7417616b0860aac5677d10291c5bb06c42a126a 100644

--- a/build/android/pylib/monkey/test_runner.py

+++ b/build/android/pylib/monkey/test_runner.py

@@ -87,7 +87,10 @@ class TestRunner(base_test_runner.BaseTestRunner):

result = base_test_result.BaseTestResult(

test_name, base_test_result.ResultType.FAIL, log=output)

if 'chrome' in self._options.package:

- logging.warning('Start MinidumpUploadService...')

- self.adb.StartCrashUploadService(self._package)

+ logging.warning('Starting MinidumpUploadService...')

+ try:

+ self.adb.StartCrashUploadService(self._package)

+ except AssertionError, e:

craigdh 2013/11/27 21:40:43 "except AssertionError as e:" is more standard for

frankf 2013/11/27 21:44:41 Done.

+ logging.error('Failed to start MinidumpUploadService: %s', e)

results.AddResult(result)

return results, False

« no previous file with comments | « no previous file | no next file » | no next file with comments »