Source/platform/heap/ThreadState.cpp - Issue 927213002: [Oilpan] Set stack limit using estimated sizes (Re-land)

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/platform/heap/ThreadState.cpp

Issue 927213002: [Oilpan] Set stack limit using estimated sizes (Re-land) (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master

Patch Set: Expand the loop Created 5 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: Source/platform/heap/ThreadState.cpp

diff --git a/Source/platform/heap/ThreadState.cpp b/Source/platform/heap/ThreadState.cpp

index fb3061f56e3381ea5b25ba375bc969e1aa2da6e7..230801275137e5a862d5e2eac9e0a07f05a0ff62 100644

--- a/Source/platform/heap/ThreadState.cpp

+++ b/Source/platform/heap/ThreadState.cpp

@@ -254,7 +254,9 @@ ThreadState::ThreadState()

if (isMainThread()) {

s_mainThreadStackStart = reinterpret_cast<uintptr_t>(m_startOfStack) - sizeof(void*);

- s_mainThreadUnderestimatedStackSize = StackFrameDepth::getUnderestimatedStackSize() - sizeof(void*);

+ size_t underestimatedStackSize = StackFrameDepth::getUnderestimatedStackSize();

+ if (underestimatedStackSize > 0)

haraken 2015/02/17 14:48:49 underestimatedStackSize >= sizeof(void*)

peria 2015/02/18 02:45:59 Done.

+ s_mainThreadUnderestimatedStackSize = underestimatedStackSize - sizeof(void*);

}

for (int heapIndex = 0; heapIndex < LargeObjectHeapIndex; heapIndex++)

« no previous file with comments | « Source/platform/heap/StackFrameDepth.cpp ('k') | no next file » | no next file with comments »