Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(770)

Side by Side Diff: net/quic/quic_flags.cc

Issue 927173002: deprecating FLAGS_quic_ack_notifier_informed_on_serialized. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@Saves_a_full_packet_allocation_86104715
Patch Set: Created 5 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « net/quic/quic_flags.h ('k') | net/quic/quic_sent_packet_manager.cc » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2014 The Chromium Authors. All rights reserved. 1 // Copyright 2014 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "net/quic/quic_flags.h" 5 #include "net/quic/quic_flags.h"
6 6
7 bool FLAGS_quic_allow_oversized_packets_for_test = false; 7 bool FLAGS_quic_allow_oversized_packets_for_test = false;
8 8
9 // When true, the use time based loss detection instead of nack. 9 // When true, the use time based loss detection instead of nack.
10 bool FLAGS_quic_use_time_loss_detection = false; 10 bool FLAGS_quic_use_time_loss_detection = false;
(...skipping 34 matching lines...) Expand 10 before | Expand all | Expand 10 after
45 // store multiple addresses. 45 // store multiple addresses.
46 bool FLAGS_quic_use_multiple_address_in_source_tokens = false; 46 bool FLAGS_quic_use_multiple_address_in_source_tokens = false;
47 47
48 // If true, uses the last sent packet for the RTO timer instead of the earliest. 48 // If true, uses the last sent packet for the RTO timer instead of the earliest.
49 bool FLAGS_quic_rto_uses_last_sent = true; 49 bool FLAGS_quic_rto_uses_last_sent = true;
50 50
51 // If true, attach QuicAckNotifiers to packets rather than individual stream 51 // If true, attach QuicAckNotifiers to packets rather than individual stream
52 // frames. 52 // frames.
53 bool FLAGS_quic_attach_ack_notifiers_to_packets = true; 53 bool FLAGS_quic_attach_ack_notifiers_to_packets = true;
54 54
55 // If true, the AckNotifierManager is informed about new packets as soon as they
56 // are serialized.
57 bool FLAGS_quic_ack_notifier_informed_on_serialized = true;
58
59 // If true, QUIC will use the new RTO that waits until an ack arrives to adjust 55 // If true, QUIC will use the new RTO that waits until an ack arrives to adjust
60 // the congestion window. 56 // the congestion window.
61 bool FLAGS_quic_use_new_rto = true; 57 bool FLAGS_quic_use_new_rto = true;
62 58
63 // Time period for which a given connection_id should live in the time-wait 59 // Time period for which a given connection_id should live in the time-wait
64 // state. 60 // state.
65 int64 FLAGS_quic_time_wait_list_seconds = 5; 61 int64 FLAGS_quic_time_wait_list_seconds = 5;
66 62
67 // Currently, this number is quite conservative. The max QPS limit for an 63 // Currently, this number is quite conservative. The max QPS limit for an
68 // individual server silo is currently set to 1000 qps, though the actual max 64 // individual server silo is currently set to 1000 qps, though the actual max
69 // that we see in the wild is closer to 450 qps. Regardless, this means that the 65 // that we see in the wild is closer to 450 qps. Regardless, this means that the
70 // longest time-wait list we should see is 5 seconds * 1000 qps = 5000. If we 66 // longest time-wait list we should see is 5 seconds * 1000 qps = 5000. If we
71 // allow for an order of magnitude leeway, we have 50000. 67 // allow for an order of magnitude leeway, we have 50000.
72 // 68 //
73 // Maximum number of connections on the time-wait list. A negative value implies 69 // Maximum number of connections on the time-wait list. A negative value implies
74 // no configured limit. 70 // no configured limit.
75 int64 FLAGS_quic_time_wait_list_max_connections = 50000; 71 int64 FLAGS_quic_time_wait_list_max_connections = 50000;
76 72
77 // If true, limit the number of connections on the quic time-wait list using a 73 // If true, limit the number of connections on the quic time-wait list using a
78 // flag. 74 // flag.
79 bool FLAGS_quic_limit_time_wait_list_size = true; 75 bool FLAGS_quic_limit_time_wait_list_size = true;
OLDNEW
« no previous file with comments | « net/quic/quic_flags.h ('k') | net/quic/quic_sent_packet_manager.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698