Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(517)

Unified Diff: test/cctest/test-migrations.cc

Issue 927153002: GCMole issues fixes (part 2). (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@master
Patch Set: Created 5 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: test/cctest/test-migrations.cc
diff --git a/test/cctest/test-migrations.cc b/test/cctest/test-migrations.cc
index 1bbaf9228191ef74759ba22e609754c795c8c3c0..94071bb508b7cb852b9accf67c0c2113743c6c33 100644
--- a/test/cctest/test-migrations.cc
+++ b/test/cctest/test-migrations.cc
@@ -572,9 +572,10 @@ static void TestGeneralizeRepresentation(Representation from_representation,
CHECK(!active_map->is_deprecated());
// Update all deprecated maps and check that they are now the same.
- CHECK_EQ(*active_map, *Map::Update(map));
+ Handle<Map> updated_map = Map::Update(map);
+ CHECK_EQ(*active_map, *updated_map);
for (int i = 0; i < kPropCount; i++) {
- Handle<Map> updated_map = Map::Update(maps[i]);
+ updated_map = Map::Update(maps[i]);
CHECK_EQ(*active_map, *updated_map);
}
}
@@ -835,7 +836,8 @@ TEST(GeneralizeRepresentationWithAccessorProperties) {
CHECK(!active_map->is_deprecated());
// Update all deprecated maps and check that they are now the same.
- CHECK_EQ(*active_map, *Map::Update(map));
+ Handle<Map> updated_map = Map::Update(map);
+ CHECK_EQ(*active_map, *updated_map);
for (int i = 0; i < kPropCount; i++) {
Handle<Map> updated_map = Map::Update(maps[i]);
Michael Starzinger 2015/02/16 18:40:20 nit: Could re-use local variable as well.
Igor Sheludko 2015/02/16 18:44:05 Done.
CHECK_EQ(*active_map, *updated_map);
@@ -1556,9 +1558,10 @@ static void TestGeneralizeRepresentationWithSpecialTransition(
CHECK(!active_map->is_deprecated());
// Update all deprecated maps and check that they are now the same.
- CHECK_EQ(*active_map, *Map::Update(map));
+ Handle<Map> updated_map = Map::Update(map);
+ CHECK_EQ(*active_map, *updated_map);
for (int i = 0; i < kPropCount; i++) {
- Handle<Map> updated_map = Map::Update(maps[i]);
+ updated_map = Map::Update(maps[i]);
CHECK_EQ(*active_map, *updated_map);
}
}
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698