Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(41)

Issue 927153002: GCMole issues fixes (part 2). (Closed)

Created:
5 years, 10 months ago by Igor Sheludko
Modified:
5 years, 10 months ago
Reviewers:
Michael Starzinger
CC:
v8-dev
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

GCMole issues fixes (part 2). R=mstarzinger@chromium.org Committed: https://crrev.com/90734ca1866dac634517c05715a2d565a9074f6c Cr-Commit-Position: refs/heads/master@{#26674}

Patch Set 1 #

Total comments: 2

Patch Set 2 : Addressed comments #

Unified diffs Side-by-side diffs Delta from patch set Stats (+9 lines, -6 lines) Patch
M test/cctest/test-migrations.cc View 1 3 chunks +9 lines, -6 lines 0 comments Download

Messages

Total messages: 6 (2 generated)
Michael Starzinger
LGTM, just one nit. https://codereview.chromium.org/927153002/diff/1/test/cctest/test-migrations.cc File test/cctest/test-migrations.cc (right): https://codereview.chromium.org/927153002/diff/1/test/cctest/test-migrations.cc#newcode842 test/cctest/test-migrations.cc:842: Handle<Map> updated_map = Map::Update(maps[i]); nit: ...
5 years, 10 months ago (2015-02-16 18:40:20 UTC) #2
Igor Sheludko
https://codereview.chromium.org/927153002/diff/1/test/cctest/test-migrations.cc File test/cctest/test-migrations.cc (right): https://codereview.chromium.org/927153002/diff/1/test/cctest/test-migrations.cc#newcode842 test/cctest/test-migrations.cc:842: Handle<Map> updated_map = Map::Update(maps[i]); On 2015/02/16 18:40:20, Michael Starzinger ...
5 years, 10 months ago (2015-02-16 18:44:05 UTC) #4
commit-bot: I haz the power
Patchset 2 (id:??) landed as https://crrev.com/90734ca1866dac634517c05715a2d565a9074f6c Cr-Commit-Position: refs/heads/master@{#26674}
5 years, 10 months ago (2015-02-16 18:48:32 UTC) #5
Igor Sheludko
5 years, 10 months ago (2015-02-16 18:48:33 UTC) #6
Message was sent while issue was closed.
Committed patchset #2 (id:20001) manually as
90734ca1866dac634517c05715a2d565a9074f6c (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698