Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(167)

Issue 927143002: [strong] Adding regression cases which should always continue working. (Closed)

Created:
5 years, 10 months ago by marja
Modified:
5 years, 10 months ago
Reviewers:
rossberg
CC:
v8-dev
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[strong] Adding regression cases which should always continue working. 1) Mutually recursive functions 2) Strong code using non-strong var before declaration. These test cases ensure that we don't accidentally kill these wanted behaviors when adding restrictions to strong mode. BUG= Committed: https://crrev.com/868470ddc9b9b731a2315adcbdfd03b7bdcc3de2 Cr-Commit-Position: refs/heads/master@{#26671}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+45 lines, -0 lines) Patch
A test/mjsunit/strong/mutually-recursive-funcs.js View 1 chunk +25 lines, -0 lines 0 comments Download
A test/mjsunit/strong/use-before-var.js View 1 chunk +20 lines, -0 lines 0 comments Download

Messages

Total messages: 7 (2 generated)
marja
rossberg, ptal
5 years, 10 months ago (2015-02-16 17:31:01 UTC) #2
rossberg
lgtm
5 years, 10 months ago (2015-02-16 17:32:36 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/927143002/1
5 years, 10 months ago (2015-02-16 17:35:58 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 10 months ago (2015-02-16 17:57:38 UTC) #6
commit-bot: I haz the power
5 years, 10 months ago (2015-02-16 17:57:50 UTC) #7
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/868470ddc9b9b731a2315adcbdfd03b7bdcc3de2
Cr-Commit-Position: refs/heads/master@{#26671}

Powered by Google App Engine
This is Rietveld 408576698