Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(727)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 927113002: Add TypeChecking=Unrestricted to SVG{Matrix,Rect,Point} (Closed)

Created:
5 years, 10 months ago by fs
Modified:
5 years, 10 months ago
CC:
blink-reviews, krit, arv+blink, vivekg_samsung, kouhei+svg_chromium.org, fs, vivekg, ed+blinkwatch_opera.com, f(malita), Inactive, gyuyoung.kim_webkit.org, Stephen Chennney, rwlbuis, pdr+svgwatchlist_chromium.org
Target Ref:
refs/heads/master
Project:
blink
Visibility:
Public.

Description

Add TypeChecking=Unrestricted to SVG{Matrix,Rect,Point} Convert all float/double attributes/arguments into unrestricted such in order to match the corresponding DOM* type from the Geometry spec. - since this is what SVG2 will be replacing these types with. BUG=354298, 311246 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=190264

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+22 lines, -22 lines) Patch
M Source/core/svg/SVGMatrix.idl View 1 chunk +14 lines, -14 lines 0 comments Download
M Source/core/svg/SVGPoint.idl View 1 chunk +3 lines, -3 lines 0 comments Download
M Source/core/svg/SVGRect.idl View 1 chunk +5 lines, -5 lines 0 comments Download

Messages

Total messages: 8 (3 generated)
fs
5 years, 10 months ago (2015-02-16 16:31:18 UTC) #2
Erik Dahlström (inactive)
lgtm
5 years, 10 months ago (2015-02-16 16:57:29 UTC) #3
kouhei (in TOK)
lgtm
5 years, 10 months ago (2015-02-16 16:59:00 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/927113002/1
5 years, 10 months ago (2015-02-16 17:36:54 UTC) #7
commit-bot: I haz the power
5 years, 10 months ago (2015-02-16 17:40:00 UTC) #8
Message was sent while issue was closed. 
Committed patchset #1 (id:1) as
https://src.chromium.org/viewvc/blink?view=rev&revision=190264

Powered by Google App Engine
This is Rietveld 408576698