Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(136)

Issue 927083003: Fix a failure in test_api.js when accessibility auditing is not enabled. (Closed)

Created:
5 years, 10 months ago by Peter Lundblad
Modified:
5 years, 10 months ago
Reviewers:
Dan Beam
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Fix a failure in test_api.js when accessibility auditing is not enabled. Tests that don't enable auditing generate a confusing stack trace and a setUp method that would call its base method by virtue of good practice will not work. BUG=458910 Committed: https://crrev.com/04fde03c302535b6d52da89d5c8c1cd0dac11d2e Cr-Commit-Position: refs/heads/master@{#316570}

Patch Set 1 #

Patch Set 2 : Fix tests. #

Patch Set 3 : window['axs'] -> window.axs #

Patch Set 4 : window is not available in the jsunit environment, use goog.global. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+17 lines, -9 lines) Patch
M chrome/test/data/webui/test_api.js View 1 2 3 2 chunks +17 lines, -9 lines 0 comments Download

Messages

Total messages: 10 (3 generated)
Peter Lundblad
5 years, 10 months ago (2015-02-16 15:00:34 UTC) #1
Paweł Hajdan Jr.
Please get this reviewed by someone working on accessibility. My stamp for chrome/test/data shouldn't even ...
5 years, 10 months ago (2015-02-16 15:16:04 UTC) #2
Peter Lundblad
Changing reviewer to Dan.
5 years, 10 months ago (2015-02-16 15:35:10 UTC) #4
Dan Beam
lgtm, though window.axs is mildly preferred
5 years, 10 months ago (2015-02-17 06:48:06 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/927083003/60001
5 years, 10 months ago (2015-02-17 13:57:21 UTC) #8
commit-bot: I haz the power
Committed patchset #4 (id:60001)
5 years, 10 months ago (2015-02-17 14:00:28 UTC) #9
commit-bot: I haz the power
5 years, 10 months ago (2015-02-17 14:01:13 UTC) #10
Message was sent while issue was closed.
Patchset 4 (id:??) landed as
https://crrev.com/04fde03c302535b6d52da89d5c8c1cd0dac11d2e
Cr-Commit-Position: refs/heads/master@{#316570}

Powered by Google App Engine
This is Rietveld 408576698