Support videos with JPEG color range in GPU YUV convert path.

cc/quads/yuv_video_draw_quad.h

 // Copyright 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #ifndef CC_QUADS_YUV_VIDEO_DRAW_QUAD_H_
 #define CC_QUADS_YUV_VIDEO_DRAW_QUAD_H_
 
 #include "base/basictypes.h"
 #include "base/memory/scoped_ptr.h"
 #include "cc/base/cc_export.h"
 #include "cc/layers/video_layer_impl.h"
 #include "cc/quads/draw_quad.h"
 
 namespace cc {
 
 class CC_EXPORT YUVVideoDrawQuad : public DrawQuad {
  public:
+  enum ColorSpace {
+    kRec601,       // SDTV standard with restricted "studio swing" color range.
+    kRec601_Jpeg,  // Full color range [0, 255] variant of the above.
+  };

[Tom Sepez, 2014/05/02 00:25:37]

Generally, the way we do this is by adding a constant:
ColorSpace_LAST = kRec601_jpeg
to the enum duplicating the highest value (naming this to suit your preferences
is ceratianly ok). Then, in your *_messages.h file, your
IPC_ENUM_TRAITS_MAX_VALUE() declaration would use ColorSpace_LAST, rather than
kRec601_jpeg, so that down the road, if someone adds a new case, the messages
file need not be changed.

Otherwise, its fine.

[piman, 2014/05/02 00:37:28]

nit: we use ALL_CAPS style for enum values in chromium, for consistency.

+
   virtual ~YUVVideoDrawQuad();
 
   static scoped_ptr<YUVVideoDrawQuad> Create();
 
   void SetNew(const SharedQuadState* shared_quad_state,
               const gfx::Rect& rect,
               const gfx::Rect& opaque_rect,
               const gfx::Rect& visible_rect,
               const gfx::RectF& tex_coord_rect,
               unsigned y_plane_resource_id,
               unsigned u_plane_resource_id,
               unsigned v_plane_resource_id,
-              unsigned a_plane_resource_id);
+              unsigned a_plane_resource_id,
+              ColorSpace color_space);
 
   void SetAll(const SharedQuadState* shared_quad_state,
               const gfx::Rect& rect,
               const gfx::Rect& opaque_rect,
               const gfx::Rect& visible_rect,
               bool needs_blending,
               const gfx::RectF& tex_coord_rect,
               unsigned y_plane_resource_id,
               unsigned u_plane_resource_id,
               unsigned v_plane_resource_id,
-              unsigned a_plane_resource_id);
+              unsigned a_plane_resource_id,
+              ColorSpace color_space);
 
   gfx::RectF tex_coord_rect;
   unsigned y_plane_resource_id;
   unsigned u_plane_resource_id;
   unsigned v_plane_resource_id;
   unsigned a_plane_resource_id;
+  ColorSpace color_space;
 
   virtual void IterateResources(const ResourceIteratorCallback& callback)
       OVERRIDE;
 
   static const YUVVideoDrawQuad* MaterialCast(const DrawQuad*);
 
  private:
   YUVVideoDrawQuad();
   virtual void ExtendValue(base::DictionaryValue* value) const OVERRIDE;
 };
 
 }  // namespace cc
 
 #endif  // CC_QUADS_YUV_VIDEO_DRAW_QUAD_H_