Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(677)

Issue 926993002: Add text continuation to app info dialog buttons (Closed)

Created:
5 years, 10 months ago by tsergeant
Modified:
5 years, 10 months ago
Reviewers:
sashab
CC:
chromium-reviews, chrome-apps-syd-reviews_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Add text continuation to app info dialog buttons Adds an ellipsis to the 'Create shortcuts' and 'Remove' buttons, which both require additional user input. BUG=448359 Committed: https://crrev.com/78afb85b32b013e2b8af772e0dc36d3bb5c04808 Cr-Commit-Position: refs/heads/master@{#316926}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -4 lines) Patch
M chrome/app/generated_resources.grd View 4 chunks +4 lines, -4 lines 0 comments Download

Messages

Total messages: 7 (2 generated)
tsergeant
5 years, 10 months ago (2015-02-16 06:10:07 UTC) #2
sashab
lgtm upon approval from UI in the bug.
5 years, 10 months ago (2015-02-18 05:18:36 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/926993002/1
5 years, 10 months ago (2015-02-18 22:44:51 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 10 months ago (2015-02-18 23:55:57 UTC) #6
commit-bot: I haz the power
5 years, 10 months ago (2015-02-18 23:56:24 UTC) #7
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/78afb85b32b013e2b8af772e0dc36d3bb5c04808
Cr-Commit-Position: refs/heads/master@{#316926}

Powered by Google App Engine
This is Rietveld 408576698