Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(588)

Issue 926973002: Update adb_remote_setup.sh to use git repository. (Closed)

Created:
5 years, 10 months ago by nyquist
Modified:
5 years, 10 months ago
Reviewers:
newt (away)
CC:
chromium-reviews, klundberg+watch_chromium.org, yfriedman+watch_chromium.org, jbudorick+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Update adb_remote_setup.sh to use git repository. Currently the adb_remote_setup.sh uses the SVN repository to update itself. Given that chromium has moved hosting to use git, it should use that repository as its canonical source. Gitiles currently does not have support for directly downloading the raw contents of a file, but it is possible to download it as base64 encoded data. This is a security precaution to ensure that browsers do not accidentally act upon the downloaded data. More info can be found in this issue: https://code.google.com/p/gitiles/issues/detail?id=7 This CL updates the canonical script URL, and changes the update-self function to base64 decode the downloaded data before storing it in the new script file. BUG=None Committed: https://crrev.com/2a985fe809b2c72c78341d8accadfaf721e26005 Cr-Commit-Position: refs/heads/master@{#317998}

Patch Set 1 #

Total comments: 2

Patch Set 2 : Add support for running script on Linux. #

Patch Set 3 : Use --decode as param #

Unified diffs Side-by-side diffs Delta from patch set Stats (+7 lines, -2 lines) Patch
M tools/android/adb_remote_setup.sh View 1 2 1 chunk +7 lines, -2 lines 0 comments Download

Messages

Total messages: 12 (2 generated)
nyquist
newt: PTAL
5 years, 10 months ago (2015-02-16 03:36:25 UTC) #2
newt (away)
https://codereview.chromium.org/926973002/diff/1/tools/android/adb_remote_setup.sh File tools/android/adb_remote_setup.sh (right): https://codereview.chromium.org/926973002/diff/1/tools/android/adb_remote_setup.sh#newcode19 tools/android/adb_remote_setup.sh:19: curl -sSf "$script_url" | base64 -D > "$new_script" || ...
5 years, 10 months ago (2015-02-17 18:30:30 UTC) #3
nyquist
newt: PTAL https://codereview.chromium.org/926973002/diff/1/tools/android/adb_remote_setup.sh File tools/android/adb_remote_setup.sh (right): https://codereview.chromium.org/926973002/diff/1/tools/android/adb_remote_setup.sh#newcode19 tools/android/adb_remote_setup.sh:19: curl -sSf "$script_url" | base64 -D > ...
5 years, 10 months ago (2015-02-17 19:16:27 UTC) #4
nyquist
tried this at home, and this seems to work well on mac os x as ...
5 years, 10 months ago (2015-02-19 15:29:21 UTC) #5
newt (away)
lgtm Sad that -d (or -D) doesn't work on all platforms
5 years, 10 months ago (2015-02-19 18:48:58 UTC) #6
nyquist
newt: PTAL. went with using --decode. Tested on Mac OS X and Linux.
5 years, 10 months ago (2015-02-25 03:42:03 UTC) #7
newt (away)
On 2015/02/25 03:42:03, nyquist wrote: > newt: PTAL. went with using --decode. Tested on Mac ...
5 years, 10 months ago (2015-02-25 05:00:59 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/926973002/40001
5 years, 10 months ago (2015-02-25 06:06:48 UTC) #10
commit-bot: I haz the power
Committed patchset #3 (id:40001)
5 years, 10 months ago (2015-02-25 06:54:30 UTC) #11
commit-bot: I haz the power
5 years, 10 months ago (2015-02-25 07:07:35 UTC) #12
Message was sent while issue was closed.
Patchset 3 (id:??) landed as
https://crrev.com/2a985fe809b2c72c78341d8accadfaf721e26005
Cr-Commit-Position: refs/heads/master@{#317998}

Powered by Google App Engine
This is Rietveld 408576698