Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(637)

Issue 926913002: Oilpan: leave out TreeScope::dispose(). (Closed)

Created:
5 years, 10 months ago by sof
Modified:
5 years, 10 months ago
Reviewers:
oilpan-reviews, haraken
CC:
blink-reviews, blink-reviews-dom_chromium.org, dglazkov+blink, sof, eae+blinkwatch, rwlbuis
Target Ref:
refs/heads/master
Project:
blink
Visibility:
Public.

Description

Oilpan: leave out TreeScope::dispose(). Leave out base dispose() method from TreeScope's vtable when Oilpan is enabled; unused. R=haraken BUG=340522 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=190191

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -2 lines) Patch
M Source/core/dom/TreeScope.h View 2 chunks +1 line, -2 lines 0 comments Download

Messages

Total messages: 6 (2 generated)
sof
Please take a look.
5 years, 10 months ago (2015-02-15 12:14:47 UTC) #2
haraken
LGTM
5 years, 10 months ago (2015-02-15 16:56:35 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/926913002/1
5 years, 10 months ago (2015-02-15 17:12:06 UTC) #5
commit-bot: I haz the power
5 years, 10 months ago (2015-02-15 17:14:38 UTC) #6
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://src.chromium.org/viewvc/blink?view=rev&revision=190191

Powered by Google App Engine
This is Rietveld 408576698