Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(594)

Unified Diff: sky/engine/core/script/dart_loader.h

Issue 926753002: Improve DartLoader error handling. (Closed) Base URL: git@github.com:domokit/mojo.git@master
Patch Set: Created 5 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: sky/engine/core/script/dart_loader.h
diff --git a/sky/engine/core/script/dart_loader.h b/sky/engine/core/script/dart_loader.h
index 188ddb5fda21c65fcc9a0f70b80f8c31f0309502..078712ab1dd3e5d60e62715e54eca3d99bfc6145 100644
--- a/sky/engine/core/script/dart_loader.h
+++ b/sky/engine/core/script/dart_loader.h
@@ -43,6 +43,7 @@ class DartLoader {
}
DartState* dart_state() const { return dart_state_.get(); }
+ bool saw_error() const { return saw_error_; }
private:
class Job;
@@ -55,12 +56,14 @@ class DartLoader {
Dart_Handle Source(Dart_Handle library, Dart_Handle url);
void DidCompleteImportJob(ImportJob* job, const Vector<uint8_t>& buffer);
void DidCompleteSourceJob(SourceJob* job, const Vector<uint8_t>& buffer);
+ void DidFailJob(Job* job);
base::WeakPtr<DartState> dart_state_;
HashMap<String, Job*> pending_libraries_;
HashSet<OwnPtr<Job>> jobs_;
HashSet<OwnPtr<DependencyWatcher>> dependency_watchers_;
DartDependencyCatcher* dependency_catcher_;
+ bool saw_error_;
DISALLOW_COPY_AND_ASSIGN(DartLoader);
};

Powered by Google App Engine
This is Rietveld 408576698