Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(441)

Side by Side Diff: sky/engine/tonic/dart_error.cc

Issue 926753002: Improve DartLoader error handling. (Closed) Base URL: git@github.com:domokit/mojo.git@master
Patch Set: Remove saw_error Created 5 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright 2015 The Chromium Authors. All rights reserved. 1 // Copyright 2015 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "sky/engine/config.h" 5 #include "sky/engine/config.h"
6 #include "sky/engine/tonic/dart_error.h" 6 #include "sky/engine/tonic/dart_error.h"
7 7
8 #include "base/logging.h" 8 #include "base/logging.h"
9 9
10 namespace blink { 10 namespace blink {
11 11
12 namespace DartError { 12 namespace DartError {
13 13
14 const char kInvalidArgument[] = "Invalid argument."; 14 const char kInvalidArgument[] = "Invalid argument.";
15 15
16 } // namespace DartError 16 } // namespace DartError
17 17
18 bool LogIfError(Dart_Handle handle) { 18 bool LogIfError(Dart_Handle handle) {
19 if (Dart_IsError(handle)) { 19 if (Dart_IsError(handle)) {
20 LOG(ERROR) << Dart_GetError(handle); 20 LOG(ERROR) << Dart_GetError(handle);
21
22 // Only unhandled exceptions have stacktraces.
23 if (!Dart_ErrorHasException(handle))
24 return true;
25
26 Dart_Handle stacktrace = Dart_ErrorGetStacktrace(handle);
27 const char* stacktrace_cstr = "";
28 Dart_StringToCString(Dart_ToString(stacktrace), &stacktrace_cstr);
29 LOG(ERROR) << stacktrace_cstr;
21 return true; 30 return true;
22 } 31 }
23 return false; 32 return false;
24 } 33 }
25 34
26 } // namespace blink 35 } // namespace blink
OLDNEW
« sky/engine/core/script/dart_loader.cc ('K') | « sky/engine/core/script/dart_loader.cc ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698