Improve DartLoader error handling.

sky/engine/core/script/dart_loader.cc

 // Copyright 2015 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "sky/engine/config.h"
 #include "sky/engine/core/script/dart_loader.h"
 
 #include "base/callback.h"
 #include "mojo/common/data_pipe_drainer.h"
 #include "sky/engine/core/script/dart_dependency_catcher.h"
@@ skipping 41 matching lines @@
   const KURL& url() const { return url_; }
 
  protected:
   DartLoader* loader_;
   // TODO(abarth): Should we be using SharedBuffer to buffer the data?
   Vector<uint8_t> buffer_;
 
  private:
   // MojoFetcher::Client
   void OnReceivedResponse(mojo::URLResponsePtr response) override {
-    // TODO(abarth): Handle network errors.
+    if (response->status_code != 200) {
+      loader_->DidFailJob(this);
+      return;
+    }
     drainer_ = adoptPtr(new DataPipeDrainer(this, response->body.Pass()));
   }
 
   // DataPipeDrainer::Client
   void OnDataAvailable(const void* data, size_t num_bytes) override {
     buffer_.append(static_cast<const uint8_t*>(data), num_bytes);
   }
   // Subclasses must implement OnDataComplete.
 
   KURL url_;
@@ skipping 95 matching lines @@
       callback.Run();
   }
 
  private:
   DartLoader& loader_;
   OwnPtr<DartDependencyCatcher> catcher_;
   DartDependency* resolved_dependency_;
 };
 
 DartLoader::DartLoader(DartState* dart_state)
-    : dart_state_(dart_state->GetWeakPtr()), dependency_catcher_(nullptr) {
+    : dart_state_(dart_state->GetWeakPtr()),
+      dependency_catcher_(nullptr) {

[abarth-chromium, 2015/02/14 00:28:06]

git cl format will probably undo this change.

 }
 
 DartLoader::~DartLoader() {
 }
 
 Dart_Handle DartLoader::HandleLibraryTag(Dart_LibraryTag tag,
                                          Dart_Handle library,
                                          Dart_Handle url) {
   DCHECK(Dart_IsLibrary(library));
   DCHECK(Dart_IsString(url));
@@ skipping 66 matching lines @@
   WatcherSignaler watcher_signaler(*this, job);
 
   LogIfError(Dart_LoadSource(
       Dart_HandleFromPersistent(job->library()),
       StringToDart(dart_state_.get(), job->url().string()),
       Dart_NewStringFromUTF8(buffer.data(), buffer.size()), 0, 0));
 
   jobs_.remove(job);
 }
 
+void DartLoader::DidFailJob(Job* job) {
+  DCHECK(dart_state_);
+  DartIsolateScope scope(dart_state_->isolate());
+  DartApiScope api_scope;
+
+  WatcherSignaler watcher_signaler(*this, job);
+
+  LOG(ERROR) << "Library Load failed: " << job->url().string().utf8().data();
+  // TODO(eseidel): Call Dart_LibraryHandleError in the SourceJob case?
+
+  jobs_.remove(job);
+}
+
 }  // namespace blink