Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(543)

Issue 926723002: Fixed directions for release build. (Closed)

Created:
5 years, 10 months ago by jimbe
Modified:
5 years, 10 months ago
Reviewers:
jamesr
CC:
mojo-reviews_chromium.org
Base URL:
https://github.com/domokit/mojo.git@master
Target Ref:
refs/heads/master
Project:
mojo
Visibility:
Public.

Description

Patch Set 1 #

Patch Set 2 : Cleaned up inconsistencies #

Total comments: 2
Unified diffs Side-by-side diffs Delta from patch set Stats (+17 lines, -13 lines) Patch
M README.md View 1 7 chunks +17 lines, -13 lines 2 comments Download

Messages

Total messages: 10 (2 generated)
jimbe
5 years, 10 months ago (2015-02-13 21:14:53 UTC) #2
jamesr
lgtm, although maybe these should all prefer debug
5 years, 10 months ago (2015-02-13 21:15:44 UTC) #3
jimbe
On 2015/02/13 at 21:31:11, jimbe wrote: > New patchsets have been uploaded after l-g-t-m from ...
5 years, 10 months ago (2015-02-13 21:32:45 UTC) #5
jamesr
https://codereview.chromium.org/926723002/diff/20001/README.md File README.md (right): https://codereview.chromium.org/926723002/diff/20001/README.md#newcode38 README.md:38: $ ninja -C out/Debug -j 10 can you update ...
5 years, 10 months ago (2015-02-13 22:27:22 UTC) #6
jimbe
https://codereview.chromium.org/926723002/diff/20001/README.md File README.md (right): https://codereview.chromium.org/926723002/diff/20001/README.md#newcode38 README.md:38: $ ninja -C out/Debug -j 10 On 2015/02/13 22:27:22, ...
5 years, 10 months ago (2015-02-14 00:44:50 UTC) #7
jamesr
Ah, I see. That's fine then.
5 years, 10 months ago (2015-02-14 00:50:11 UTC) #8
jamesr
(still lgtm if you were waiting)
5 years, 10 months ago (2015-02-18 22:46:31 UTC) #9
jimbe
5 years, 10 months ago (2015-02-18 22:56:04 UTC) #10
Message was sent while issue was closed.
Committed patchset #2 (id:20001) manually as
0ac4ba45ca77ce9f13769a0a34489f5020edb217 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698