Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(230)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 926693002: Remove android specific srcPath from SkPath (Closed)

Created:
5 years, 10 months ago by djsollen
Modified:
5 years, 10 months ago
Reviewers:
bsalomon, reed1
CC:
reviews_skia.org
Base URL:
https://skia.googlesource.com/skia.git@master
Target Ref:
refs/heads/master
Project:
skia
Visibility:
Public.

Description

Remove android specific srcPath from SkPath Committed: https://skia.googlesource.com/skia/+/523cda39435256bcb3e5665f47612d661d3c6bf9

Patch Set 1 #

Patch Set 2 : remove test case #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -83 lines) Patch
M include/core/SkPath.h View 2 chunks +1 line, -6 lines 0 comments Download
M src/core/SkPath.cpp View 5 chunks +2 lines, -25 lines 0 comments Download
M tests/PathTest.cpp View 1 2 chunks +0 lines, -52 lines 0 comments Download

Messages

Total messages: 12 (5 generated)
djsollen
5 years, 10 months ago (2015-02-13 19:36:04 UTC) #2
reed1
woot-g-t-m lgtm
5 years, 10 months ago (2015-02-13 19:52:07 UTC) #3
djsollen
5 years, 10 months ago (2015-02-13 19:54:41 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/926693002/1
5 years, 10 months ago (2015-02-13 19:55:06 UTC) #6
commit-bot: I haz the power
Try jobs failed on following builders: Build-Ubuntu13.10-GCC4.8-Arm7-Debug-Android-Trybot on client.skia.compile (JOB_FAILED, http://build.chromium.org/p/client.skia.compile/builders/Build-Ubuntu13.10-GCC4.8-Arm7-Debug-Android-Trybot/builds/2025)
5 years, 10 months ago (2015-02-13 19:57:27 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/926693002/20001
5 years, 10 months ago (2015-02-17 15:59:51 UTC) #11
commit-bot: I haz the power
5 years, 10 months ago (2015-02-17 16:06:37 UTC) #12
Message was sent while issue was closed. 
Committed patchset #2 (id:20001) as
https://skia.googlesource.com/skia/+/523cda39435256bcb3e5665f47612d661d3c6bf9

Powered by Google App Engine
This is Rietveld 408576698