chrome/browser/renderer_host/render_process_host_chrome_browsertest.cc - Issue 926663002: Handle RenderProcessHostImpl::SetBackgrounded on Windows

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/renderer_host/render_process_host_chrome_browsertest.cc

Issue 926663002: Handle RenderProcessHostImpl::SetBackgrounded on Windows (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@908473002_ps2

Patch Set: as an experiment Created 5 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « base/process/process_win.cc ('k') | content/browser/renderer_host/render_process_host_impl.cc » ('j') | content/browser/renderer_host/render_process_host_impl.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/renderer_host/render_process_host_chrome_browsertest.cc

diff --git a/chrome/browser/renderer_host/render_process_host_chrome_browsertest.cc b/chrome/browser/renderer_host/render_process_host_chrome_browsertest.cc

index 72add927696654b4711f540c351d2b306cb72318..3af07310d830162c3fec50daad6493244d19b40f 100644

--- a/chrome/browser/renderer_host/render_process_host_chrome_browsertest.cc

+++ b/chrome/browser/renderer_host/render_process_host_chrome_browsertest.cc

@@ -291,13 +291,7 @@ IN_PROC_BROWSER_TEST_F(ChromeRenderProcessHostTest, MAYBE_ProcessPerTab) {

// We don't change process priorities on Mac or Posix because the user lacks the

// permission to raise a process' priority even after lowering it.

#if defined(OS_WIN) || defined(OS_LINUX)

-#if defined(OS_WIN)

-// Flaky test: crbug.com/394368

-#define MAYBE_Backgrounding DISABLED_Backgrounding

-#else

-#define MAYBE_Backgrounding Backgrounding

-#endif

-IN_PROC_BROWSER_TEST_F(ChromeRenderProcessHostTest, MAYBE_Backgrounding) {

+IN_PROC_BROWSER_TEST_F(ChromeRenderProcessHostTest, Backgrounding) {

if (!base::Process::CanBackgroundProcesses()) {

LOG(ERROR) << "Can't background processes";

return;