Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(499)

Issue 926593007: Add //ipc to "gn check", work on base (Closed)

Created:
5 years, 10 months ago by brettw
Modified:
5 years, 10 months ago
Reviewers:
jamesr, jam
CC:
chromium-reviews, Dai Mikurube (NOT FULLTIME), qsr+mojo_chromium.org, viettrungluu+watch_chromium.org, wfh+watch_chromium.org, yzshen+watch_chromium.org, abarth-chromium, Aaron Boodman, darin (slow to review), erikwright+watch_chromium.org, ben+mojo_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Add //ipc to "gn check", work on base This fixes the header issues in these directories and adds them to the list of targets to be checked. Committed: https://crrev.com/e75311d05a5839a37e20dbf8998080f2db9627ab Cr-Commit-Position: refs/heads/master@{#316705}

Patch Set 1 #

Total comments: 1

Patch Set 2 : tcmalloc #

Patch Set 3 : Visibility for Android #

Patch Set 4 : updates #

Patch Set 5 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+31 lines, -4 lines) Patch
M .gn View 1 2 3 1 chunk +8 lines, -1 line 0 comments Download
M base/BUILD.gn View 2 chunks +5 lines, -0 lines 0 comments Download
M base/allocator/BUILD.gn View 1 2 chunks +5 lines, -1 line 0 comments Download
M base/third_party/nspr/BUILD.gn View 1 2 1 chunk +4 lines, -1 line 0 comments Download
M build/config/android/rules.gni View 1 2 3 4 1 chunk +5 lines, -0 lines 0 comments Download
M ipc/BUILD.gn View 1 chunk +1 line, -0 lines 0 comments Download
M ipc/mojo/BUILD.gn View 2 chunks +3 lines, -1 line 0 comments Download

Messages

Total messages: 14 (4 generated)
brettw
5 years, 10 months ago (2015-02-14 00:46:23 UTC) #2
jamesr
https://codereview.chromium.org/926593007/diff/1/base/allocator/BUILD.gn File base/allocator/BUILD.gn (right): https://codereview.chromium.org/926593007/diff/1/base/allocator/BUILD.gn#newcode157 base/allocator/BUILD.gn:157: "//base", Hmm, is this what this code is actually ...
5 years, 10 months ago (2015-02-14 00:49:41 UTC) #3
brettw
On 2015/02/14 00:49:41, jamesr wrote: > https://codereview.chromium.org/926593007/diff/1/base/allocator/BUILD.gn > File base/allocator/BUILD.gn (right): > > https://codereview.chromium.org/926593007/diff/1/base/allocator/BUILD.gn#newcode157 > ...
5 years, 10 months ago (2015-02-14 00:56:43 UTC) #4
brettw
PTAL. I had to disable base bit worked it out so that it will pass ...
5 years, 10 months ago (2015-02-17 18:33:50 UTC) #5
brettw
=> jam
5 years, 10 months ago (2015-02-17 20:23:42 UTC) #7
jam
cool lgtm
5 years, 10 months ago (2015-02-17 23:12:48 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/926593007/80001
5 years, 10 months ago (2015-02-17 23:53:47 UTC) #10
commit-bot: I haz the power
Committed patchset #5 (id:80001)
5 years, 10 months ago (2015-02-17 23:56:58 UTC) #11
commit-bot: I haz the power
Patchset 5 (id:??) landed as https://crrev.com/e75311d05a5839a37e20dbf8998080f2db9627ab Cr-Commit-Position: refs/heads/master@{#316705}
5 years, 10 months ago (2015-02-17 23:57:29 UTC) #12
jamesr
5 years, 10 months ago (2015-02-18 18:45:43 UTC) #14
Message was sent while issue was closed.
lgtm as well.

Powered by Google App Engine
This is Rietveld 408576698