Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2259)

Unified Diff: chrome/android/java/strings/android_chrome_strings.grd

Issue 926593006: [App banners] Update accessibility strings (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Cleaning up more accessibility differences Created 5 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/android/java/strings/android_chrome_strings.grd
diff --git a/chrome/android/java/strings/android_chrome_strings.grd b/chrome/android/java/strings/android_chrome_strings.grd
index e330f5d1c31e2cdbc1907ea5f98474b984ca7d21..0d3501e039592b5924d9fa7513011e06b1d832f0 100644
--- a/chrome/android/java/strings/android_chrome_strings.grd
+++ b/chrome/android/java/strings/android_chrome_strings.grd
@@ -829,14 +829,27 @@ You are signing in with a managed account and giving its administrator control o
</message>
<!-- App banner accessibility strings, used for touch exploration -->
+ <message name="IDS_APP_BANNER_VIEW_NATIVE_APP_ACCESSIBILITY" desc="Accessibililty text: Describes a prompt promoting the installation of an app related to the current page, including its app name and rating.">
+ Prompt to get app from the Google Play Store. App name: <ph name="APP_NAME">%1$s<ex>Gmail</ex></ph>. App average rating: <ph name="APP_RATING">%2$.1f<ex>4.2</ex></ph>.
newt (away) 2015/02/13 23:49:59 This reads oddly to me. How about: "Install app fr
gone 2015/02/13 23:52:09 Sometimes it costs money.
gone 2015/02/13 23:57:13 That and this message is used for the whole banner
+ </message>
+ <message name="IDS_APP_BANNER_VIEW_NATIVE_APP_ICON_ACCESSIBILITY" desc="Accessibililty text: Indicates that the user is hovering over the app icon and that clicking it will take the user to the Play Store.">
+ Click to open the Play Store page for the app: <ph name="APP_NAME">%1$s<ex>Gmail</ex></ph>.
+ </message>
+ <message name="IDS_APP_BANNER_VIEW_NATIVE_APP_INSTALL_ACCESSIBILITY" desc="Accessibility text: Indicates that clicking on the button will purchase the app or install it.">
newt (away) 2015/02/13 23:49:58 I don't think the button needs a content descripti
gone 2015/02/13 23:52:09 Sometimes it's a currency amount.
newt (away) 2015/02/14 00:00:19 True. But what does a sighted user see? "$0.99" or
+ Get the app from the Google Play Store: <ph name="APP_ACTION">%s<ex>Install</ex></ph>
+ </message>
+ <message name="IDS_APP_BANNER_VIEW_NATIVE_APP_RATING_ACCESSIBILITY" desc="Accessibililty text: Indicates the Play Store rating of the app being promoted by the current page.">
+ App average rating: <ph name="APP_RATING">%1$.1f<ex>4.2</ex></ph>.
newt (away) 2015/02/13 23:49:58 I'd remove "average" and maybe "app" too. It might
+ </message>
+
<message name="IDS_APP_BANNER_VIEW_WEB_APP_ACCESSIBILITY" desc="Accessibililty text: Describes the banner content, including the app name and its URL.">
- Prompt to add page to the homescreen. App name: <ph name="APP_NAME">%1$s<ex>Gmail</ex></ph>. App URL: <ph name="APP_URL">%2$s<ex>http://gmail.com</ex></ph>.
+ Prompt to add a promoted page to the homescreen. App name: <ph name="APP_NAME">%1$s<ex>Gmail</ex></ph>.
newt (away) 2015/02/13 23:49:58 "Add web app to homescreen. App name: Gmail"
</message>
- <message name="IDS_APP_BANNER_VIEW_NATIVE_APP_ACCESSIBILITY" desc="Accessibililty text: Describes the banner content, including the app name and rating.">
- Prompt to get app from the Google Play Store. App name: <ph name="APP_NAME">%1$s<ex>Gmail</ex></ph>. App average rating: <ph name="APP_RATING">%2$.1f<ex>4.2</ex></ph>.
+ <message name="IDS_APP_BANNER_VIEW_WEB_APP_ICON_ACCESSIBILITY" desc="Accessibililty text: Indicates that the user is hovering over an icon representing an app being promoted by the current web page.">
+ Icon for the app: <ph name="APP_NAME">%1$s<ex>Gmail</ex></ph>.
</message>
- <message name="IDS_APP_BANNER_INSTALL_ACCESSIBILITY" desc="Accessibility text: Indicates that clicking on the button will purchase the app or install it.">
- Get app from the Google Play Store: <ph name="APP_ACTION">%s<ex>Install</ex></ph>
+ <message name="IDS_APP_BANNER_VIEW_WEB_APP_INSTALL_ACCESSIBILITY" desc="Accessibility text: Indicates that the user is hovering over a button to add the app being promoted by the current web page to the user's homescreen">
+ Add the app to your homescreen: <ph name="APP_ACTION">%s<ex>Add to homescreen</ex></ph>
</message>
<!-- DOM Distiller strings -->

Powered by Google App Engine
This is Rietveld 408576698