Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(383)

Unified Diff: chrome/android/java/src/org/chromium/chrome/browser/infobar/AppBannerInfoBar.java

Issue 926593006: [App banners] Update accessibility strings (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 5 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/android/java/src/org/chromium/chrome/browser/infobar/AppBannerInfoBar.java
diff --git a/chrome/android/java/src/org/chromium/chrome/browser/infobar/AppBannerInfoBar.java b/chrome/android/java/src/org/chromium/chrome/browser/infobar/AppBannerInfoBar.java
index 5c57008960c38f305e6eb1ea6591130cfe3ff2e7..fe982d09e46bda099524ecd77ed3c01bc81d6e37 100644
--- a/chrome/android/java/src/org/chromium/chrome/browser/infobar/AppBannerInfoBar.java
+++ b/chrome/android/java/src/org/chromium/chrome/browser/infobar/AppBannerInfoBar.java
@@ -89,6 +89,9 @@ public class AppBannerInfoBar extends ConfirmInfoBar implements View.OnClickList
layout.setCustomViewInButtonRow(playLogo);
ratingView.setRating(mAppData.rating());
+ ratingView.setContentDescription(context.getString(
+ R.string.app_banner_view_native_app_rating_accessibility, mAppData.rating()));
+
layout.getPrimaryButton().setButtonColor(getContext().getResources().getColor(
R.color.app_banner_install_button_bg));
layout.setContentDescription(context.getString(
@@ -106,7 +109,11 @@ public class AppBannerInfoBar extends ConfirmInfoBar implements View.OnClickList
// Set up clicking on the controls to bring up the app details.
mTitleView.setOnClickListener(this);
- if (mIconView != null) mIconView.setOnClickListener(this);
+ if (mIconView != null) {
+ mIconView.setOnClickListener(this);
+ mIconView.setContentDescription(context.getString(
+ R.string.app_banner_view_icon_accessibility, mAppTitle));
+ }
}
@Override

Powered by Google App Engine
This is Rietveld 408576698