Use SkXfermode as public facing enum for GrPorterDuffXP

include/gpu/effects/GrCoverageSetOpXP.h

Index: include/gpu/effects/GrCoverageSetOpXP.h
diff --git a/src/gpu/effects/GrCoverageSetOpXP.h b/include/gpu/effects/GrCoverageSetOpXP.h
similarity index 68%
rename from src/gpu/effects/GrCoverageSetOpXP.h
rename to include/gpu/effects/GrCoverageSetOpXP.h
index 01dce952116cf85409880da5bc0094d8b9be64f0..004cc3d679ce516abe32aac541b0da02c9a4892c 100644
--- a/src/gpu/effects/GrCoverageSetOpXP.h
+++ b/include/gpu/effects/GrCoverageSetOpXP.h
@@ -14,16 +14,22 @@
 
 class GrProcOptInfo;
 
+/**
+ * This xfer processor directly blends the the src coverage with the dst using a set operator. It is
+ * useful for rendering coverage masks using CSG. It can optionally invert the src coverage before
+ * applying the set operator.
+ * */

[bsalomon, 2015/02/14 20:45:59]

extra space?

 class GrCoverageSetOpXPFactory : public GrXPFactory {
 public:
     static GrXPFactory* Create(SkRegion::Op regionOp, bool invertCoverage = false);
 
-    bool supportsRGBCoverage(GrColor knownColor, uint32_t knownColorFlags) const SK_OVERRIDE {
+    bool supportsRGBCoverage(GrColor /*knownColor*/,
+                             uint32_t /*knownColorFlags*/) const SK_OVERRIDE {
         return true;
     }
 
-    bool canApplyCoverage(const GrProcOptInfo& colorPOI,
-                          const GrProcOptInfo& coveragePOI) const SK_OVERRIDE {
+    bool canApplyCoverage(const GrProcOptInfo& /*colorPOI*/,
+                          const GrProcOptInfo& /*coveragePOI*/) const SK_OVERRIDE {
         return true;
     }
 
@@ -39,8 +45,8 @@ private:
                                            const GrProcOptInfo& coveragePOI,
                                            const GrDeviceCoordTexture* dstCopy) const SK_OVERRIDE;
 
-    bool willReadDstColor(const GrProcOptInfo& colorPOI,
-                          const GrProcOptInfo& coveragePOI) const SK_OVERRIDE {
+    bool willReadDstColor(const GrProcOptInfo& /*colorPOI*/,
+                          const GrProcOptInfo& /*coveragePOI*/) const SK_OVERRIDE {
         return false;
     }