include/gpu/effects/GrPorterDuffXferProcessor.h - Issue 926593005: Use SkXfermode as public facing enum for GrPorterDuffXP

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: include/gpu/effects/GrPorterDuffXferProcessor.h

Issue 926593005: Use SkXfermode as public facing enum for GrPorterDuffXP (Closed) Base URL: https://skia.googlesource.com/skia.git@master

Patch Set: Created 5 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: include/gpu/effects/GrPorterDuffXferProcessor.h

diff --git a/include/gpu/effects/GrPorterDuffXferProcessor.h b/include/gpu/effects/GrPorterDuffXferProcessor.h

index 1bd199370e2a22c27b1ea5a89821ccb7537d1d03..15edcbb81e6c842e5651d58a0543556aa2211554 100644

--- a/include/gpu/effects/GrPorterDuffXferProcessor.h

+++ b/include/gpu/effects/GrPorterDuffXferProcessor.h

@@ -22,10 +22,6 @@ public:

return SkNEW_ARGS(GrPorterDuffXPFactory, ((GrBlendCoeff)(src), (GrBlendCoeff)(dst)));

}

- static GrXPFactory* Create(GrBlendCoeff src, GrBlendCoeff dst) {

- return SkNEW_ARGS(GrPorterDuffXPFactory, (src, dst));

- }

bool supportsRGBCoverage(GrColor knownColor, uint32_t knownColorFlags) const SK_OVERRIDE;

bool canApplyCoverage(const GrProcOptInfo& colorPOI,