Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(208)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 926563002: Move Iterable.h and Maplike.h to bindings/core/v8/ (Closed)

Created:
5 years, 10 months ago by Jens Widell
Modified:
5 years, 10 months ago
Reviewers:
haraken
CC:
blink-reviews, blink-reviews-dom_chromium.org, feature-media-reviews_chromium.org, blink-reviews-html_chromium.org, arv+blink, vivekg_samsung, sof, eae+blinkwatch, eric.carlson_apple.com, vivekg, dglazkov+blink, blink-reviews-bindings_chromium.org, philipj_slow, rwlbuis
Base URL:
https://chromium.googlesource.com/chromium/blink.git@master
Target Ref:
refs/heads/master
Project:
blink
Visibility:
Public.

Description

Move Iterable.h and Maplike.h to bindings/core/v8/ BUG=432683 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=190141

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+7 lines, -244 lines) Patch
A + Source/bindings/core/v8/Iterable.h View 0 chunks +-1 lines, --1 lines 0 comments Download
A + Source/bindings/core/v8/Maplike.h View 1 chunk +1 line, -1 line 0 comments Download
M Source/bindings/core/v8/v8.gypi View 1 chunk +2 lines, -0 lines 0 comments Download
M Source/core/core.gypi View 1 chunk +0 lines, -1 line 0 comments Download
D Source/core/dom/Iterable.h View 1 chunk +0 lines, -201 lines 0 comments Download
D Source/core/dom/Maplike.h View 1 chunk +0 lines, -37 lines 0 comments Download
M Source/core/html/DOMFormData.h View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/testing/Internals.h View 1 chunk +1 line, -1 line 0 comments Download
M Source/modules/encryptedmedia/MediaKeyStatusMap.h View 1 chunk +1 line, -1 line 0 comments Download
M Source/modules/fetch/Headers.h View 1 chunk +1 line, -1 line 0 comments Download
M Source/modules/webmidi/MIDIPortMap.h View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 6 (2 generated)
Jens Widell
PTAL Having thought some about it, I think it makes more sense that these live ...
5 years, 10 months ago (2015-02-13 10:08:23 UTC) #2
haraken
LGTM
5 years, 10 months ago (2015-02-13 11:33:41 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/926563002/1
5 years, 10 months ago (2015-02-13 11:35:32 UTC) #5
commit-bot: I haz the power
5 years, 10 months ago (2015-02-13 12:59:26 UTC) #6
Message was sent while issue was closed. 
Committed patchset #1 (id:1) as
https://src.chromium.org/viewvc/blink?view=rev&revision=190141

Powered by Google App Engine
This is Rietveld 408576698