Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(4445)

Unified Diff: chrome/browser/ui/views/frame/browser_view_layout.cc

Issue 9265018: Change grow box computation back to a method on BrowserWindow (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: nits Created 8 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/ui/views/frame/browser_view_layout.cc
diff --git a/chrome/browser/ui/views/frame/browser_view_layout.cc b/chrome/browser/ui/views/frame/browser_view_layout.cc
index cc28697c939b5dd5a1c94da3a0a3446fd9770596..3a54b5dd7ab6060455e1949ee36ab1a3cfecd25a 100644
--- a/chrome/browser/ui/views/frame/browser_view_layout.cc
+++ b/chrome/browser/ui/views/frame/browser_view_layout.cc
@@ -382,36 +382,6 @@ int BrowserViewLayout::LayoutInfoBar(int top) {
return overlapped_top + height;
}
-// |browser_reserved_rect| is in browser_view_ coordinates.
-// |future_source_bounds| is in |source|'s parent coordinates.
-// |future_parent_offset| is required, since parent view is not moved yet.
-// Note that |future_parent_offset| is relative to browser_view_, not to
-// the parent view.
-void BrowserViewLayout::UpdateReservedContentsRect(
- const gfx::Rect& browser_reserved_rect,
- TabContentsContainer* source,
- const gfx::Rect& future_source_bounds,
- const gfx::Point& future_parent_offset) {
- gfx::Point resize_corner_origin(browser_reserved_rect.origin());
- // Convert |resize_corner_origin| from browser_view_ to source's parent
- // coordinates.
- views::View::ConvertPointToView(browser_view_, source->parent(),
- &resize_corner_origin);
- // Create |reserved_rect| in source's parent coordinates.
- gfx::Rect reserved_rect(resize_corner_origin, browser_reserved_rect.size());
- // Apply source's parent future offset to it.
- reserved_rect.Offset(-future_parent_offset.x(), -future_parent_offset.y());
- if (future_source_bounds.Intersects(reserved_rect)) {
- // |source| is not properly positioned yet to use ConvertPointToView,
- // so convert it into |source|'s coordinates manually.
- reserved_rect.Offset(-future_source_bounds.x(), -future_source_bounds.y());
- } else {
- reserved_rect = gfx::Rect();
- }
-
- source->SetReservedContentsRect(reserved_rect);
-}
-
void BrowserViewLayout::LayoutTabContents(int top, int bottom) {
// The ultimate idea is to calculate bounds and reserved areas for all
// contents views first and then resize them all, so every view
@@ -447,15 +417,6 @@ void BrowserViewLayout::LayoutTabContents(int top, int bottom) {
}
}
- UpdateReservedContentsRect(browser_reserved_rect,
- browser_view_->contents_container_,
- contents_bounds,
- contents_split_offset);
- UpdateReservedContentsRect(browser_reserved_rect,
- browser_view_->devtools_container_,
- devtools_bounds,
- contents_split_offset);
-
// Now it's safe to actually resize all contents views in the hierarchy.
contents_split_->SetBoundsRect(contents_split_bounds);
}
« no previous file with comments | « chrome/browser/ui/views/frame/browser_view_layout.h ('k') | chrome/browser/ui/views/tab_contents/tab_contents_container.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698