|
|
Created:
5 years, 10 months ago by fukino Modified:
5 years, 10 months ago Reviewers:
hirono CC:
chromium-reviews, rginda+watch_chromium.org, mtomasz+watch_chromium.org Base URL:
https://chromium.googlesource.com/chromium/src.git@master Target Ref:
refs/pending/heads/master Project:
chromium Visibility:
Public. |
DescriptionFiles.app: Make all columns resizable in table view.
BUG=458356
TEST=manually tested by dragging each separator on the column header.
Committed: https://crrev.com/e6dded12a7ba3281b4889369beef653c8389a3f0
Cr-Commit-Position: refs/heads/master@{#316382}
Patch Set 1 #
Total comments: 2
Messages
Total messages: 20 (8 generated)
fukino@chromium.org changed reviewers: + hirono@chromium.org
PTAL. Thanks!
Thanks! lgtm https://codereview.chromium.org/926483003/diff/1/ui/file_manager/file_manager... File ui/file_manager/file_manager/foreground/js/ui/file_table.js (right): https://codereview.chromium.org/926483003/diff/1/ui/file_manager/file_manager... ui/file_manager/file_manager/foreground/js/ui/file_table.js:126: if (columnIndex < 0 || nit: We can remove the check, or assert?
Thank! https://codereview.chromium.org/926483003/diff/1/ui/file_manager/file_manager... File ui/file_manager/file_manager/foreground/js/ui/file_table.js (right): https://codereview.chromium.org/926483003/diff/1/ui/file_manager/file_manager... ui/file_manager/file_manager/foreground/js/ui/file_table.js:126: if (columnIndex < 0 || On 2015/02/13 06:46:22, hirono wrote: > nit: We can remove the check, or assert? Maybe we can use assert, but some investigation is needed to prove it. Let me this range-check as is for now.
The CQ bit was checked by fukino@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/926483003/1
The CQ bit was unchecked by commit-bot@chromium.org
Try jobs failed on following builders: linux_chromium_chromeos_rel_ng on tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)
The CQ bit was checked by fukino@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/926483003/1
The CQ bit was unchecked by commit-bot@chromium.org
Try jobs failed on following builders: linux_chromium_chromeos_rel_ng on tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)
The CQ bit was checked by fukino@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/926483003/1
The CQ bit was unchecked by commit-bot@chromium.org
Try jobs failed on following builders: linux_chromium_chromeos_rel_ng on tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)
The CQ bit was checked by fukino@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/926483003/1
Message was sent while issue was closed.
Committed patchset #1 (id:1)
Message was sent while issue was closed.
Patchset 1 (id:??) landed as https://crrev.com/e6dded12a7ba3281b4889369beef653c8389a3f0 Cr-Commit-Position: refs/heads/master@{#316382} |