Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(233)

Issue 926483003: Files.app: Make all columns resizable in table view. (Closed)

Created:
5 years, 10 months ago by fukino
Modified:
5 years, 10 months ago
Reviewers:
hirono
CC:
chromium-reviews, rginda+watch_chromium.org, mtomasz+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Files.app: Make all columns resizable in table view. BUG=458356 TEST=manually tested by dragging each separator on the column header. Committed: https://crrev.com/e6dded12a7ba3281b4889369beef653c8389a3f0 Cr-Commit-Position: refs/heads/master@{#316382}

Patch Set 1 #

Total comments: 2
Unified diffs Side-by-side diffs Delta from patch set Stats (+8 lines, -23 lines) Patch
M ui/file_manager/file_manager/foreground/js/ui/file_table.js View 6 chunks +8 lines, -23 lines 2 comments Download

Messages

Total messages: 20 (8 generated)
fukino
PTAL. Thanks!
5 years, 10 months ago (2015-02-13 06:39:55 UTC) #2
hirono
Thanks! lgtm https://codereview.chromium.org/926483003/diff/1/ui/file_manager/file_manager/foreground/js/ui/file_table.js File ui/file_manager/file_manager/foreground/js/ui/file_table.js (right): https://codereview.chromium.org/926483003/diff/1/ui/file_manager/file_manager/foreground/js/ui/file_table.js#newcode126 ui/file_manager/file_manager/foreground/js/ui/file_table.js:126: if (columnIndex < 0 || nit: We ...
5 years, 10 months ago (2015-02-13 06:46:22 UTC) #3
fukino
Thank! https://codereview.chromium.org/926483003/diff/1/ui/file_manager/file_manager/foreground/js/ui/file_table.js File ui/file_manager/file_manager/foreground/js/ui/file_table.js (right): https://codereview.chromium.org/926483003/diff/1/ui/file_manager/file_manager/foreground/js/ui/file_table.js#newcode126 ui/file_manager/file_manager/foreground/js/ui/file_table.js:126: if (columnIndex < 0 || On 2015/02/13 06:46:22, ...
5 years, 10 months ago (2015-02-13 06:54:42 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/926483003/1
5 years, 10 months ago (2015-02-13 11:26:33 UTC) #6
commit-bot: I haz the power
Try jobs failed on following builders: linux_chromium_chromeos_rel_ng on tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_chromeos_rel_ng/builds/24749)
5 years, 10 months ago (2015-02-13 12:31:11 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/926483003/1
5 years, 10 months ago (2015-02-13 12:39:40 UTC) #10
commit-bot: I haz the power
Try jobs failed on following builders: linux_chromium_chromeos_rel_ng on tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_chromeos_rel_ng/builds/24772)
5 years, 10 months ago (2015-02-13 13:33:30 UTC) #12
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/926483003/1
5 years, 10 months ago (2015-02-13 14:55:45 UTC) #14
commit-bot: I haz the power
Try jobs failed on following builders: linux_chromium_chromeos_rel_ng on tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_chromeos_rel_ng/builds/24820)
5 years, 10 months ago (2015-02-13 15:52:16 UTC) #16
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/926483003/1
5 years, 10 months ago (2015-02-14 09:27:27 UTC) #18
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 10 months ago (2015-02-14 09:28:10 UTC) #19
commit-bot: I haz the power
5 years, 10 months ago (2015-02-14 09:29:02 UTC) #20
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/e6dded12a7ba3281b4889369beef653c8389a3f0
Cr-Commit-Position: refs/heads/master@{#316382}

Powered by Google App Engine
This is Rietveld 408576698