Remove SK_SUPPORT_LEGACY_ADDOVAL

Remove SK_SUPPORT_LEGACY_ADDOVAL

BUG=458898
TBR=reed@google.com
NOTRY=true

Committed: https://chromium.googlesource.com/chromium/src/+/93f64cca160bc0f987405f8f15ba06d13716f002

[f(malita), 2015-03-06 15:51:34]

Trying to add suppressions in preparation for landing, but I noticed some odd
results:

https://storage.googleapis.com/chromium-layout-test-archives/win_blink_rel/53...

https://storage.googleapis.com/chromium-layout-test-archives/win_blink_rel/53...

Small circles scaled up significantly seem to have squarish corners.

Strangely enough I cannot repro when opening the test in browser/content_shell -
only when running layout tests...

[f(malita), 2015-03-06 16:32:07]

On 2015/03/06 15:51:34, f(malita) wrote:
> Trying to add suppressions in preparation for landing, but I noticed some odd
> results:
> 
>
https://storage.googleapis.com/chromium-layout-test-archives/win_blink_rel/53...
> 
>
https://storage.googleapis.com/chromium-layout-test-archives/win_blink_rel/53...
> 
> Small circles scaled up significantly seem to have squarish corners.
> 
> Strangely enough I cannot repro when opening the test in browser/content_shell
-
> only when running layout tests...

Mystery solved: this is triggered by the pathops clipping path, which is only
active for layout tests. I'll try to minimize.

[f(malita), 2015-03-09 00:06:54]

Also had to deal with cc_unittests failures in PS#2:

http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...


Apparently cc_unittests has its own checked-in baseline PNGs ?!

Anyway, I think this is finally ready to land with ~640 suppressions.

[f(malita), 2015-03-09 00:15:42]

The CQ bit was checked by fmalita@chromium.org

[commit-bot: I haz the power, 2015-03-09 00:16:11]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/926403002/60001

[commit-bot: I haz the power, 2015-03-09 02:13:26]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2015-03-09 02:13:27]

Failed to apply the patch.

[commit-bot: I haz the power, 2015-03-09 02:13:29]

The CQ bit was unchecked by commit-bot@chromium.org

[f(malita), 2015-03-09 02:16:04]

The CQ bit was checked by fmalita@chromium.org

[commit-bot: I haz the power, 2015-03-09 02:16:13]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/926403002/60001

[commit-bot: I haz the power, 2015-03-09 02:16:38]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2015-03-09 02:16:39]

Failed to apply the patch.

[commit-bot: I haz the power, 2015-03-09 02:16:40]

The CQ bit was unchecked by commit-bot@chromium.org

[f(malita), 2015-03-09 02:17:22]

The CQ bit was checked by fmalita@chromium.org

[commit-bot: I haz the power, 2015-03-09 02:18:13]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/926403002/80001

[f(malita), 2015-03-09 02:18:39]

The CQ bit was unchecked by fmalita@chromium.org

[f(malita), 2015-03-09 02:19:53]

The CQ bit was checked by fmalita@chromium.org

[commit-bot: I haz the power, 2015-03-09 02:20:22]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/926403002/80001

[commit-bot: I haz the power, 2015-03-09 02:20:44]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2015-03-09 02:20:45]

Failed to apply the patch.

[commit-bot: I haz the power, 2015-03-09 02:20:47]

The CQ bit was unchecked by commit-bot@chromium.org

[f(malita), 2015-03-09 02:22:21]

On 2015/03/09 02:20:45, I haz the power (commit-bot) wrote:
> Failed to apply the patch.

for crying out loud :(

[commit-bot: I haz the power, 2015-03-09 02:30:22]

Patchset 5 (id:??) landed as
https://crrev.com/93f64cca160bc0f987405f8f15ba06d13716f002
Cr-Commit-Position: refs/heads/master@{#319598}

[f(malita), 2015-03-09 02:30:31]

Committed patchset #5 (id:80001) manually as
93f64cca160bc0f987405f8f15ba06d13716f002 (presubmit successful).